Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 - prevent crash on empty payload #22

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Conversation

lennym
Copy link
Owner

@lennym lennym commented Nov 10, 2017

No description provided.

Not uploading any file will cause `Buffer.byteLength` to throw an error if called with an empty array in node >= 7, which is what `concat-stream` will return if no payload is provided.

Remove `concat-stream` in favour of `bl`, which will reliably callback with Buffer instances for empty streams.
@lennym lennym merged commit 9a51fba into master Nov 10, 2017
@lennym lennym deleted the bugfix/crash-on-empty branch November 10, 2017 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant