Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RobotoMono font not loaded when terminal opened first time #5019

Closed
aleksfront opened this issue Mar 16, 2022 · 3 comments · Fixed by #5117 or #6913
Closed

RobotoMono font not loaded when terminal opened first time #5019

aleksfront opened this issue Mar 16, 2022 · 3 comments · Fixed by #5117 or #6913
Assignees
@ixrock
Labels
area/ui bug Something isn't working
Milestone
6.4.0

Comments

@aleksfront
Copy link
Contributor

To reproduce:

  1. If located in cluster view, choose "Cluster" -> "Disconnect" from the sidebar menu
  2. Open cluster again.
  3. Open terminal tab.

fonts not loaded

Firstly, this issue occurred within webpack 5 update:
@aleksfront aleksfront added bug Something isn't working area/ui labels Mar 16, 2022
@aleksfront aleksfront added this to the 5.4.3 milestone Mar 16, 2022
@jim-docker jim-docker modified the milestones: 5.4.3, 5.4.4, 5.4.5 Mar 18, 2022
ixrock added a commit that referenced this issue Mar 28, 2022
@ixrock
always preload app fonts at earliest stages, fix #5019
150b91d 
Signed-off-by: Roman <[email protected]>
@ixrock ixrock mentioned this issue Mar 28, 2022
Merged
Nokel81 pushed a commit that referenced this issue Mar 29, 2022
@ixrock
Always preload app fonts at earliest stages (#5117)
30d22bf 
* always preload app fonts at earliest stages, fix #5019

Signed-off-by: Roman <[email protected]>

* attempt to fix tests, clean up

Signed-off-by: Roman <[email protected]>
@jim-docker jim-docker modified the milestones: 5.4.5, 5.5.0 Apr 5, 2022
@aleksfront aleksfront reopened this Nov 2, 2022
@aleksfront
Copy link
Contributor Author

Still happened sometimes on windows.

@Nokel81
Copy link
Collaborator

Nokel81 commented Nov 2, 2022

Probably as some form of race condition

@ixrock
Copy link
Contributor

ixrock commented Dec 19, 2022 •
edited
Loading

Confirming, sometimes still happens on Mac too, first time opening cluster with previously opened terminal tab:

Screenshot 2022-12-19 at 15 29 45

@Nokel81 Nokel81 modified the milestones: 5.5.0, 6.3.1, 6.4.0 Jan 10, 2023
ixrock added a commit that referenced this issue Jan 11, 2023
@ixrock
better handling loading terminal fonts timing issues, fix #5019
a1b36b6 
Signed-off-by: Roman <[email protected]>
@ixrock ixrock mentioned this issue Jan 11, 2023
Merged
Nokel81 pushed a commit that referenced this issue Jan 13, 2023
@ixrock
Better handling loading terminal fonts (#6913)
875972e 
* better handling loading terminal fonts timing issues, fix #5019

Signed-off-by: Roman <[email protected]>

* refactoring, loading all terminal fonts to earliest stage app starting

Signed-off-by: Roman <[email protected]>

* attempt to fix tests

Signed-off-by: Roman <[email protected]>

Signed-off-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixrock ixrock

Labels
area/ui bug Something isn't working
Projects
None yet
Milestone
6.4.0
4 participants
@ixrock @Nokel81 @aleksfront @jim-docker