Upgrade to webpack@5 #4725

ixrock · 2022-01-20T12:44:44Z

This also fixing nasty caching bug with UI files after combination(s) of make clean && make dev / page reload / git checkout branches / etc.

TODO:

fix unit tests
fix integration tests
fix warnings in compilation of main process (types must be imported separately in files participating in extension-api re-exports)
fix incorrect import warnings in compilation of renderer process
use @pmmmwh/react-refresh-webpack-plugin with react-refresh-typescript to support HMR in most cases

…ion -- part 1 Signed-off-by: Roman <[email protected]>

Nokel81 · 2022-01-20T17:32:38Z

Shouldn't think be marked as a chore?

ixrock · 2022-01-20T19:37:19Z

Shouldn't think be marked as a chore?

whatever :)

Signed-off-by: Roman <[email protected]>

webpack.renderer.ts

…tempt

- extending getTSLoader() to accept more options from ts-loader Signed-off-by: Roman <[email protected]>

github-actions · 2022-01-24T15:44:03Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Roman <[email protected]>

…tempt # Conflicts: # package.json # yarn.lock

Signed-off-by: Roman <[email protected]>

github-actions · 2022-01-26T12:00:12Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

…g resources via webpack Signed-off-by: Roman <[email protected]>

github-actions · 2022-01-27T15:25:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…tempt # Conflicts: # src/common/catalog-entities/kubernetes-cluster.ts

@font-face

…'s not bundled with HtmlWebpackPlugin() anyway anda all fonts loaded via css @font-face rule Signed-off-by: Roman <[email protected]>

…cripts change Signed-off-by: Roman <[email protected]>

…gin` to support HMR in most cases Signed-off-by: Roman <[email protected]>

ixrock · 2022-02-14T14:10:58Z

@lensapp/lens-maintainers PTAL, ready for testing & reviews.

HMR demo:

Screen.Recording.2022-02-14.at.16.03.19.mov

extensions/kube-object-event-status/package.json

Nokel81 · 2022-02-14T14:37:35Z

extensions/kube-object-event-status/package.json

-    "ts-loader": "^8.0.4",
-    "typescript": "^4.3.2",
-    "webpack": "^4.46.0"
+    "ts-loader": "latest",


We shouldn't use latest here because it will break if there is a mismatch of versions between this file and ../../package.json

Why it will break when it's not used in "production" / inside packed extension?
I think only ts-loader must be compatible with local webpack package.

We do run npm install on extensions, even bundled extensions.

When we do? So maybe we should move it to peerDependencies then?
Anyway I think it should be handled from parent's package version, otherwise it's just copy-pasting all around. Can we use actual versions from app's package.json on extensions install?

https://github.com/lensapp/lens/blob/master/src/extensions/extension-discovery/extension-discovery.ts#L383-L406

This is where we do the install calls

Well, it's still unclear how this installing dependency handle unpacking extension:

await this.dependencies.installExtension(extension.absolutePath);

In general it feels wrong if compiled extension require matching own development dependencies with the app (in case of react, mobx and some other packages we're sharing them via global env because version matching there is important for app's work. @jakolehm @nevalla @panuhorsmalahti wdyt?

@Nokel81 @ixrock Lens installs extension npm package without development dependencies -> extension dev dependencies don't need to match same versions on Lens side.

Note: using latest version might still be a bit risky (in general).

I think it's not more risky than just having outdated specific version == in both cases I assume it's easy to spot/fix/use what is needed per extension package.

src/renderer/components/+network-ingresses/ingress-details.tsx

webpack.extensions.ts

Signed-off-by: Roman <[email protected]>

…dev`) Signed-off-by: Roman <[email protected]>

jakolehm

LGTM

jakolehm · 2022-02-15T10:01:45Z

extensions/kube-object-event-status/package.json

-    "ts-loader": "^8.0.4",
-    "typescript": "^4.3.2",
-    "webpack": "^4.46.0"
+    "ts-loader": "latest",


Note: using latest version might still be a bit risky (in general).

aleksfront · 2022-02-15T11:24:43Z

Found 2 terminal-related issues:

Fonts don't preload properly in terminal window.
An error occured on every terminal tab close:

Uncaught TypeError: Cannot read properties of null (reading 'url')

close.tab.error.mov

Nokel81 · 2022-02-15T11:41:40Z

@aleksfront that second issue is a known issue that exists on master. I don't think it should block this PR

Nokel81

Except for the font issue. This looks good to me.

ixrock · 2022-02-15T15:02:52Z

Except for the font issue. This looks good to me.

fix is already done (gonna create new PR very soon)

This reverts commit d656a9e.

Signed-off-by: Roman <[email protected]>

ixrock added the enhancement New feature or request label Jan 20, 2022

ixrock self-assigned this Jan 20, 2022

ixrock requested a review from a team as a code owner January 20, 2022 12:44

ixrock requested review from jakolehm and jim-docker and removed request for a team January 20, 2022 12:44

ixrock marked this pull request as draft January 20, 2022 12:44

attempt to upgrade webpack@5 and all relevant packages to latest vers…

f4f937d

…ion -- part 1 Signed-off-by: Roman <[email protected]>

ixrock force-pushed the webpack5-upgrade-attempt branch from e1629d6 to f4f937d Compare January 20, 2022 12:45

ixrock added chore area/ui and removed enhancement New feature or request labels Jan 20, 2022

debugging webpack@5 usage -- part 1

ab7781f

Signed-off-by: Roman <[email protected]>

ixrock commented Jan 22, 2022

View reviewed changes

webpack.renderer.ts Show resolved Hide resolved

ixrock changed the title ~~Upgrade to webpack@5 and all relevant packages to latest versions~~ Upgrade to webpack@5 Jan 22, 2022

ixrock added 2 commits January 24, 2022 11:43

Merge remote-tracking branch 'origin/master' into webpack5-upgrade-at…

3782204

…tempt

- attempt to use "react-refresh-typescript" with webpack@5 thingy

2f382d4

- extending getTSLoader() to accept more options from ts-loader Signed-off-by: Roman <[email protected]>

github-actions bot added the PR: needs rebase label Jan 24, 2022

ixrock added 3 commits January 26, 2022 12:58

more fixes, updating webpack loaders

3267978

Signed-off-by: Roman <[email protected]>

Merge remote-tracking branch 'origin/master' into webpack5-upgrade-at…

55eebf3

…tempt # Conflicts: # package.json # yarn.lock

merge-fixes, using internal webpack@5 asset handlers (type: "asset/*")

f7a53e6

Signed-off-by: Roman <[email protected]>

github-actions bot removed the PR: needs rebase label Jan 26, 2022

fix: raw-loader / <Icon svg="./*">, updated mocked types for importin…

cae1848

…g resources via webpack Signed-off-by: Roman <[email protected]>

github-actions bot added the PR: needs rebase label Jan 27, 2022

Merge remote-tracking branch 'origin/master' into webpack5-upgrade-at…

398af8c

…tempt # Conflicts: # src/common/catalog-entities/kubernetes-cluster.ts

ixrock added 3 commits February 11, 2022 16:16

fix: removed preloading fonts in template via <link preload> since it…

ae2c937

…'s not bundled with HtmlWebpackPlugin() anyway anda all fonts loaded via css @font-face rule Signed-off-by: Roman <[email protected]>

apply HMR at least for css/styles and use manual page reload on app/s…

7d892d0

…cripts change Signed-off-by: Roman <[email protected]>

use react-refresh-typescript and `@pmmmwh/react-refresh-webpack-plu…

37667e7

…gin` to support HMR in most cases Signed-off-by: Roman <[email protected]>

Nokel81 reviewed Feb 14, 2022

View reviewed changes

ixrock added 2 commits February 14, 2022 16:58

responding to comments

be0090d

Signed-off-by: Roman <[email protected]>

revered extension version in package-lock.json (autoupdated on `make …

4576236

…dev`) Signed-off-by: Roman <[email protected]>

ixrock requested review from aleksfront and DmitriyNoa February 14, 2022 18:43

jakolehm approved these changes Feb 15, 2022

View reviewed changes

Nokel81 approved these changes Feb 15, 2022

View reviewed changes

Nokel81 added this to the 5.4.0 milestone Feb 15, 2022

ixrock merged commit d656a9e into master Feb 15, 2022

ixrock deleted the webpack5-upgrade-attempt branch February 15, 2022 15:04

ixrock mentioned this pull request Feb 15, 2022

Fix: preloading fonts for terminal #4867

Closed

jim-docker mentioned this pull request Feb 15, 2022

release v5.4.0-beta.2 #4868

Merged

jim-docker added a commit that referenced this pull request Feb 15, 2022

Revert "Upgrade to webpack@5 (#4725)"

8df6836

This reverts commit d656a9e.

jim-docker mentioned this pull request Feb 15, 2022

Revert "Upgrade to webpack@5 (#4725)" #4872

Merged

ixrock restored the webpack5-upgrade-attempt branch February 16, 2022 13:59

Nokel81 pushed a commit that referenced this pull request Feb 16, 2022

Revert "Upgrade to webpack@5 (#4725)" (#4872)

733bb54

ixrock added a commit that referenced this pull request Feb 17, 2022

upgrade to webpack@5 / reviving #4725 + #4867

4842dcf

Signed-off-by: Roman <[email protected]>

ixrock added a commit that referenced this pull request Feb 17, 2022

upgrade to webpack@5 / reviving #4725 + #4867

6b5cfee

Signed-off-by: Roman <[email protected]>

ixrock deleted the webpack5-upgrade-attempt branch February 17, 2022 13:11

ixrock added a commit that referenced this pull request Feb 17, 2022

upgrade to webpack@5 / reviving #4725 + #4867

90c7098

Signed-off-by: Roman <[email protected]>

ixrock mentioned this pull request Feb 17, 2022

Upgrade to webpack@5 #4894

Merged

aleksfront mentioned this pull request Mar 16, 2022

RobotoMono font not loaded when terminal opened first time #5019

Closed

Nokel81 mentioned this pull request May 25, 2022

Fix crash when using an inline svg Icon #5450

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to webpack@5 #4725

Upgrade to webpack@5 #4725

ixrock commented Jan 20, 2022 •

edited

Loading

Nokel81 commented Jan 20, 2022

ixrock commented Jan 20, 2022

github-actions bot commented Jan 24, 2022

github-actions bot commented Jan 26, 2022

github-actions bot commented Jan 27, 2022

ixrock commented Feb 14, 2022 •

edited

Loading

Nokel81 Feb 14, 2022

ixrock Feb 14, 2022 •

edited

Loading

Nokel81 Feb 14, 2022

ixrock Feb 14, 2022 •

edited

Loading

Nokel81 Feb 14, 2022

ixrock Feb 14, 2022

jakolehm Feb 15, 2022

jakolehm Feb 15, 2022

ixrock Feb 15, 2022

jakolehm left a comment

jakolehm Feb 15, 2022

aleksfront commented Feb 15, 2022

Nokel81 commented Feb 15, 2022 •

edited

Loading

Nokel81 left a comment

ixrock commented Feb 15, 2022

Upgrade to webpack@5 #4725

Upgrade to webpack@5 #4725

Conversation

ixrock commented Jan 20, 2022 • edited Loading

Nokel81 commented Jan 20, 2022

ixrock commented Jan 20, 2022

github-actions bot commented Jan 24, 2022

github-actions bot commented Jan 26, 2022

github-actions bot commented Jan 27, 2022

ixrock commented Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

ixrock Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ixrock Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakolehm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleksfront commented Feb 15, 2022

Nokel81 commented Feb 15, 2022 • edited Loading

Nokel81 left a comment

Choose a reason for hiding this comment

ixrock commented Feb 15, 2022

ixrock commented Jan 20, 2022 •

edited

Loading

ixrock commented Feb 14, 2022 •

edited

Loading

ixrock Feb 14, 2022 •

edited

Loading

ixrock Feb 14, 2022 •

edited

Loading

Nokel81 commented Feb 15, 2022 •

edited

Loading