Fix involuntary rerenders in item list layout #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansav
requested review from
jakolehm and
Iku-turso
and removed request for
a team
jansav
force-pushed
the
fix/involuntary-rerenders-in-item-list-layout
branch
from
2b6fab5 to
0871857
Compare
ixrock
previously approved these changes
Jan 21, 2022
src/renderer/components/item-object-list/item-list-layout-content/item-list-layout-content.tsx
Outdated
Show resolved
Hide resolved
src/renderer/components/item-object-list/item-list-layout-content/item-list-layout-content.tsx
Outdated
Show resolved
Hide resolved
src/renderer/components/item-object-list/item-list-layout-content/item-list-layout-content.tsx
Outdated
Show resolved
Hide resolved
...t-list/item-list-layout-header/item-list-layout-header-info/item-list-layout-header-info.tsx
Outdated
Show resolved
Hide resolved
...list/item-list-layout-header/item-list-layout-header-title/item-list-layout-header-title.tsx
Outdated
Show resolved
Hide resolved
src/renderer/components/item-object-list/item-list-layout-content/item-list-layout-content.tsx
Outdated
Show resolved
Hide resolved
|
One other thing what I don't really like is too much nesting in codebase (besides too much bloated amount of files): Could we keep more flat in |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jansav
force-pushed
the
fix/involuntary-rerenders-in-item-list-layout
branch
from
d3e4fde to
0b630a8
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Iku-turso
previously approved these changes
Jan 21, 2022
|
item/filtered count is missing (between Pods title and namespace selector): |
|
The list scrolls to top as it rerenders due to changes in the list items (I'm trying to keep it near the bottom, which works on 5.3.x): Screen.Recording.2022-01-21.at.12.51.41.PM.mov**** happens on master too, suspect it is due to #4653. This similar issue is still occurring as well: #4653 (comment) |
Merged
Nokel81
force-pushed
the
fix/involuntary-rerenders-in-item-list-layout
branch
from
a02f376 to
562a052
Compare
Nokel81
previously approved these changes
Jan 25, 2022
jim-docker
previously approved these changes
Jan 25, 2022
jim-docker
reviewed
Jan 25, 2022
1 task
Co-authored-by: Mikko Aspiala <[email protected]> Signed-off-by: Janne Savolainen <[email protected]>
Co-authored-by: Mikko Aspiala <[email protected]> Signed-off-by: Janne Savolainen <[email protected]>
Signed-off-by: Janne Savolainen <[email protected]>
Signed-off-by: Janne Savolainen <[email protected]>
Signed-off-by: Sebastian Malton <[email protected]>
Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
force-pushed
the
fix/involuntary-rerenders-in-item-list-layout
branch
from
81628f8 to
cf033ad
Compare
Nokel81
changed the base branch from
master
to
fix-docks-dependency-heirarchy
Nokel81
approved these changes
Jan 27, 2022
Nokel81
added a commit
that referenced
this pull request
Jan 31, 2022
* Fix involuntary re-renders in item list layout Co-authored-by: Mikko Aspiala <[email protected]> Signed-off-by: Janne Savolainen <[email protected]> * Enable skipped integration tests for being fixed Co-authored-by: Mikko Aspiala <[email protected]> Signed-off-by: Janne Savolainen <[email protected]> * Remove comment Signed-off-by: Janne Savolainen <[email protected]> * Improve code style Signed-off-by: Janne Savolainen <[email protected]> * flatten file heirarchy Signed-off-by: Sebastian Malton <[email protected]> * Fix item list layout header rendering bug Signed-off-by: Sebastian Malton <[email protected]> Co-authored-by: Sebastian Malton <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main attraction here is that
ItemListLayouthas now been split to multiple components to make re-rendering happen more locally instead of full-renders. It's also nice to have a smaller components.The changes here highlight that ItemListLayout is wrong abstraction and should be re-designed.
Closes #4703.
Opening separate issue for proper love for
ItemListLayout.Note: This PR is built on top of #4710 which should be merged first.