Fix pod logs dock tab #4738
Merged
Fix pod logs dock tab #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
jweak and
jim-docker
and removed request for
a team
- Move all dependencies into a transient LogsViewModel - Remove dependencies on dockStore.selectedTab - Make all bindings as late as possible, as per mobx rules Signed-off-by: Sebastian Malton <[email protected]>
jim-docker
approved these changes
Jan 24, 2022
| } | ||
|
|
||
| /** | ||
| * @deprecated This now only returns the empty array |
There was a problem hiding this comment.
either the comment is wrong or you forgot to change the method implementation?
There was a problem hiding this comment.
Nope, it is correct because this.logs is a getter above on line 159 which all it does is return [];
| import logTabStoreInjectable from "./tab-store.injectable"; | ||
|
|
||
| const getLogTabDataInjectable = getInjectable({ | ||
| instantiate: (di) => di.inject(logTabStoreInjectable).getData, |
There was a problem hiding this comment.
So the logTabStore is not directly a dependency but its methods are? (just seeing if I understand)
There was a problem hiding this comment.
Yes that is correct. This is one of the benefits of DI since it makes testing much easier as each of these dependencies can not be overridden individually.
You can observe this in the modified tests for log-resource-selector
jweak
approved these changes
Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all dependencies into a transient LogsViewModel
Remove dependencies on dockStore, and logTabStore
Make all bindings as late as possible, as per mobx rules
Signed-off-by: Sebastian Malton [email protected]
This fixes an integration test regression that is pressent on #4720