Skip to content

Commit

Permalink
Skip cycle detection test (pantsbuild#4361)
Browse files Browse the repository at this point in the history
### Problem

We know pantsbuild#4349 is going to miss cycle detection, we already created pantsbuild#4358 to follow up. The issue is we didn't realize we have an integration test for it, so pantsbuild#4349 was checked in around the same time pantsbuild#4340, the former was only tested in v1, and the latter turned v2 on. Now master is broken.

### Solution

Skip the failing test

### Result

Will follow up with pantsbuild#4358 next for the proper fix.
  • Loading branch information
peiyuwang authored and lenucksi committed Apr 22, 2017
1 parent 861a746 commit 4367f7d
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
unicode_literals, with_statement)

import os
import unittest

from pants_test.pants_run_integration_test import PantsRunIntegrationTest


class BuildGraphIntegrationTest(PantsRunIntegrationTest):

@unittest.skip('https://github.com/pantsbuild/pants/issues/4358')
def test_cycle(self):
prefix = 'testprojects/src/java/org/pantsbuild/testproject'
with self.file_renamed(os.path.join(prefix, 'cycle1'), 'TEST_BUILD', 'BUILD'):
Expand Down

0 comments on commit 4367f7d

Please sign in to comment.