Enable v2 engine by default. #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Mar 17, 2017
There was a problem hiding this comment.
Let's do it.
Thanks @JieGhost , @peiyuwang , @kwlzn for the collective efforts to enable this!
kwlzn
force-pushed
the
kwlzn/default_v2_engine
branch
4 times, most recently
from
57fc884 to
5c93f9d
Compare
kwlzn
force-pushed
the
kwlzn/default_v2_engine
branch
from
42408c0 to
6808c22
Compare
This reverts commit 6808c22.
kwlzn
force-pushed
the
kwlzn/default_v2_engine
branch
from
d4e2193 to
1a0d9c9
Compare
peiyuwang
added a commit
that referenced
this pull request
Mar 22, 2017
### Problem We know #4349 is going to miss cycle detection, we already created #4358 to follow up. The issue is we didn't realize we have an integration test for it, so #4349 was checked in around the same time #4340, the former was only tested in v1, and the latter turned v2 on. Now master is broken. ### Solution Skip the failing test ### Result Will follow up with #4358 next for the proper fix.
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
This enables the v2 engine by default and deprecates the `changed`-class goals.
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
### Problem We know pantsbuild#4349 is going to miss cycle detection, we already created pantsbuild#4358 to follow up. The issue is we didn't realize we have an integration test for it, so pantsbuild#4349 was checked in around the same time pantsbuild#4340, the former was only tested in v1, and the latter turned v2 on. Now master is broken. ### Solution Skip the failing test ### Result Will follow up with pantsbuild#4358 next for the proper fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the v2 engine by default and deprecates the
changed-class goals.