feat(components/memory): use common db + dmesg poller for events, move out of "dmesg" component

[gyuho]

c.f., #322

Tested:

    "component": "memory",
    "startTime": "2024-11-15T04:48:56Z",
    "endTime": "2025-01-25T02:39:01.610443725Z",
    "events": [
      {
        "time": "2025-01-25T02:38:04Z",
        "name": "memory_oom_kill_constraint",
        "type": "Warning",
        "message": "oom kill constraint detected",
        "extra_info": {
          "log_line": "oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=cri-containerd-3fc28fa1c647ceede9f6b340d0b16c9f1f663698972d22a52e296f291638e014.scope,mems_allowed=0-1,oom_memcg=/lxc.payload.ny2g2r5hh3-lxc/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-poda8697f49_441d_4d4f_90d2_6d8e1fa3bbe7.slice,task_memcg=/lxc.payload.ny2g2r5hh3-lxc/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-poda8697f49_441d_4d4f_90d2_6d8e1fa3bbe7.slice/cri-containerd-3fc28fa1c647ceede9f6b340d0b16c9f1f663698972d22a52e296f291638e014.scope,task=node,pid=863987,uid=0"
        },
        "suggested_actions": {
          "descriptions": null,
          "repair_actions": null
        }
      },
      {
        "time": "2025-01-25T02:36:53Z",
        "name": "memory_oom_kill_constraint",
        "type": "Warning",
        "message": "oom kill constraint detected",
        "extra_info": {
          "log_line": "oom-kill:constraint=OTHER_CONSTRAINT"
        },
        "suggested_actions": {
          "descriptions": null,
          "repair_actions": null
        }
      },
      {
        "time": "2025-01-25T02:36:50Z",
        "name": "memory_oom_kill_constraint",
        "type": "Warning",
        "message": "oom kill constraint detected",
        "extra_info": {
          "log_line": "oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=cri-containerd-3fc28fa1c647ceede9f6b340d0b16c9f1f663698972d22a52e296f291638e014.scope,mems_allowed=0-1,oom_memcg=/lxc.payload.ny2g2r5hh3-lxc/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-poda8697f49_441d_4d4f_90d2_6d8e1fa3bbe7.slice,task_memcg=/lxc.payload.ny2g2r5hh3-lxc/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-poda8697f49_441d_4d4f_90d2_6d8e1fa3bbe7.slice/cri-containerd-3fc28fa1c647ceede9f6b340d0b16c9f1f663698972d22a52e296f291638e014.scope,task=node,pid=863987,uid=0"
        },
        "suggested_actions": {
          "descriptions": null,
          "repair_actions": null
        }
      },
      {
        "time": "2025-01-25T02:36:46Z",
        "name": "memory_oom",
        "type": "Warning",
        "message": "oom detected",
        "extra_info": {
          "log_line": "Out of memory: Kill process 456 (python) score 50 or sacrifice child"
        },
        "suggested_actions": {
          "descriptions": null,
          "repair_actions": null
        }
      },
      {
        "time": "2025-01-25T02:36:42Z",
        "name": "memory_oom",
        "type": "Warning",
        "message": "oom detected",
        "extra_info": {
          "log_line": "Out of memory: Killed process 123, UID 48, (httpd)"
        },
        "suggested_actions": {
          "descriptions": null,
          "repair_actions": null
        }
      }
    ]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 45.04505% with 61 lines in your changes missing coverage. Please review.

Project coverage is 21.39%. Comparing base (02d1814) to head (13cc281).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
components/memory/component.go	0.00%	27 Missing ⚠️
components/memory/watcher.go	58.33%	20 Missing and 5 partials ⚠️
internal/server/server.go	0.00%	5 Missing ⚠️
pkg/dmesg/watcher.go	25.00%	3 Missing ⚠️
components/dmesg/filters.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   21.21%   21.39%   +0.18%     
==========================================
  Files         300      300              
  Lines       27089    27119      +30     
==========================================
+ Hits         5747     5803      +56     
+ Misses      20697    20667      -30     
- Partials      645      649       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eahydra]

About the test result:

IMO we only need to get an aggregated result? like OOM happened, killed processA(pid: 123)?

[gyuho]

@eahydra This is the current behavior. Needs confirmation from @cardyok if we need to aggregate.

[cardyok]

i think for dmesg errors that contains multiple lines to determine actually issue (like oom), its the best if we can aggregate it, but might make gpud logic too complicated

[gyuho]

@eahydra @cardyok

can aggregate

Oh actually, these are all different events, different log lines (just happens to be at the same time, since I injected them at the same time)

We can aggregate the event "name" to OOM or something, but those do not seem to be used anyways

[cardyok]

oh if they actually belong to different OOM event,s then i think its totally fine not aggregating them

[xiang90]

The name should not be dmesg_matched... Let us fix this. Name should be OOMed or something more descriptive.

[ccding]

it is a bit strange to cancel on error. Do we really need to create a cctx, ccancel := context.WithCancel(ctx)? Can we just use ctx for getDefaultPoller().Start and startWatch(cctx, eventsStore)?

[gyuho]

creating event store first, so we don't need call ccancel

[ccding]

@cardyok do you have any idea how to make the ctx usage look better?

[gyuho]

@ccding All fixed, thx