feat(components/db): add common events db helper #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
common-db-pkg
branch
4 times, most recently
from
76d8ebb to
2ea61d0
Compare
Signed-off-by: Gyuho Lee <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 21.19% 21.63% +0.44%
==========================================
Files 298 299 +1
Lines 26748 26916 +168
==========================================
+ Hits 5668 5823 +155
- Misses 20413 20422 +9
- Partials 667 671 +4 ☔ View full report in Codecov by Sentry. |
ccding
reviewed
Jan 24, 2025
Comment on lines
+26
to
+30
| // e.g., "xid", "sxid". | ||
| ColumnEventID1 = "event_id_1" | ||
|
|
||
| // e.g., "gpu_id", "gpu_uuid". | ||
| ColumnEventID2 = "event_id_2" |
There was a problem hiding this comment.
as discussed offline, let's rename these
| } | ||
|
|
||
| func (db *DB) Insert(ctx context.Context, ev Event) error { | ||
| return insertEvent(ctx, db.dbRW, db.table, ev) |
There was a problem hiding this comment.
do we allow one of dbRW and dbRO to be nil in the NewDB function? if yes, we should check nil before calling insertEvent
Comment on lines
+201
to
+220
| var event Event | ||
| var eventID1 sql.NullString | ||
| var eventID2 sql.NullString | ||
| if err := rows.Scan( | ||
| &event.Timestamp, | ||
| &event.DataSource, | ||
| &event.EventType, | ||
| &eventID1, | ||
| &eventID2, | ||
| &event.EventDetails, | ||
| ); err != nil { | ||
| return nil, err | ||
| } | ||
| if eventID1.Valid { | ||
| event.EventID1 = eventID1.String | ||
| } | ||
| if eventID2.Valid { | ||
| event.EventID2 = eventID2.String | ||
| } | ||
| events = append(events, event) |
There was a problem hiding this comment.
wrap this to a function to avoid duplicate code
|
Closing in favor of #332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f., #324 (comment)