Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/db): add common events store (similar to components.Event) #332

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 24, 2025

Replace #327.

Cherry-picked from #321.

@gyuho gyuho self-assigned this Jan 24, 2025
@gyuho gyuho changed the title feat(components/db): add common events store feat(components/db): add common events store (similar to components.Event) Jan 24, 2025
@gyuho gyuho force-pushed the event-db-based-on-xid branch from aebe388 to acb178f Compare January 24, 2025 04:22
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 75.44910% with 82 lines in your changes missing coverage. Please review.

Project coverage is 21.86%. Comparing base (789b4fa) to head (ab4f4ea).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/db/events.go 82.29% 36 Missing and 18 partials ⚠️
pkg/sqlite/sqlite.go 0.00% 26 Missing ⚠️
components/info/component.go 0.00% 1 Missing ⚠️
internal/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   21.22%   21.86%   +0.63%     
==========================================
  Files         298      299       +1     
  Lines       26776    27081     +305     
==========================================
+ Hits         5684     5920     +236     
- Misses      20424    20480      +56     
- Partials      668      681      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho added this to the v0.4.0 milestone Jan 24, 2025
@gyuho gyuho force-pushed the event-db-based-on-xid branch from acb178f to dec2bb2 Compare January 24, 2025 04:34
components/db/events.go Outdated Show resolved Hide resolved
@gyuho gyuho force-pushed the event-db-based-on-xid branch from 249f924 to ff04c3f Compare January 24, 2025 06:21
components/db/events.go Outdated Show resolved Hide resolved
components/db/events.go Outdated Show resolved Hide resolved
gyuho added 8 commits January 24, 2025 17:22
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho merged commit 5e4bdac into main Jan 24, 2025
6 checks passed
@gyuho gyuho deleted the event-db-based-on-xid branch January 26, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants