Set TypeScript target to es2015
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anything wrong with targeting ES5 for the build? since we use TS we can still use most of the new features since they compile down to ES5 🤔 |
|
There's nothing wrong in continuing to use es5, and this PR can be closed |
|
This PR can be merged if we decide to release 1.0.0 deprecating Node.js 6.x as suggested in #147 (comment) |
Node 6.x supports most es2015 features Details: https://node.green/#ES2015
|
@Turbo87 Can we merge this too? Node 8.x supports all ES2015 features https://node.green/#ES2015 |
Turbo87
changed the title
target to es2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal supported version, i.e. Node 6.x supports most es2015 features
Details: https://node.green/#ES2015