Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from TSLint to ESLint #147

Merged
merged 7 commits into from
Nov 11, 2019
Merged

Switch from TSLint to ESLint #147

merged 7 commits into from
Nov 11, 2019

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 29, 2019

TSLint has been deprecated:

After moving to eslint, confirmed that:

  • yarn test runs eslint
  • yarn lint runs prettier
  • yarn fix fixes lint/prettier issues
  • yarn lint is successful

@Turbo87
Copy link
Contributor

Turbo87 commented Sep 29, 2019

looks like one of the dep versions is not compatible with Node 6 though. we should probably drop Node 6 support, but it would have to be in a dedicated PR so that we can correctly label it as "breaking".

@trivikr
Copy link
Contributor Author

trivikr commented Sep 29, 2019

How about releasing v1.0.0 of lerna-changelog dropping support for Node.js v6?
It's EoL was on 2019-04-30

@Turbo87 Turbo87 changed the title feat: switch from tslint to eslint Switch from TSLint to ESLint Nov 11, 2019
@Turbo87
Copy link
Contributor

Turbo87 commented Nov 11, 2019

@trivikr can you rebase this?

@trivikr
Copy link
Contributor Author

trivikr commented Nov 11, 2019

@trivikr can you rebase this?

@Turbo87 Done!

package.json Outdated Show resolved Hide resolved
@Turbo87 Turbo87 merged commit 6e17e2c into lerna:master Nov 11, 2019
@Turbo87
Copy link
Contributor

Turbo87 commented Nov 11, 2019

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants