Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error on new CSS grid property #3092

Closed
DonCarnohan opened this issue Aug 1, 2017 · 2 comments
Closed

Parse error on new CSS grid property #3092

DonCarnohan opened this issue Aug 1, 2017 · 2 comments

Comments

@DonCarnohan
Copy link

The parser seems to not like when an area label comes before a css method like minmax.

grid-template-columns: [full-start] 1fr [content] minmax(100%, 1000px) 1fr [full-end];

The above is the example in my code. It is correct formatting for the new CSS Grid feature. Excluding it using ~" ... " causes the page to work. I just figured this shouldn't be necessary.

@seven-phases-max
Copy link
Member

seven-phases-max commented Aug 4, 2017

Not a surprise since this introduces a new grammar Less has no clue about. I'm adding "feature request" and "ready for implementation" labels with the following remark though:

Note the particular syntax is a CSS draft (i.e. not a CSS yet), they are famous for changing syntax/grammar of new features several times before TR, so when preparing the PR please be ready to maintain your code for some time (down to rewriting everything from scratch in a half of a year) - Less in its current state can't afford to support a browser developers experiments on a daily basis.

(For example see #2623)

@matthew-dean
Copy link
Member

CSS Grid is getting implemented un-prefixed in every major browser pretty much now. Support should be implemented. http://caniuse.com/#feat=css-grid

wmfgerrit pushed a commit to wikimedia/less.php that referenced this issue Jun 7, 2024
…13 behaviours

* Grid syntax (less/less.js#3092)
* Escapes in keywords (less/less.js#3268)

Bug: T288498
Change-Id: I3867cee77ad2a69ecb8e4f850fa5c548e3520b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants