Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 hack not parseable in less 3.5 #3268

Closed
Jogai opened this issue Jul 5, 2018 · 9 comments
Closed

IE8 hack not parseable in less 3.5 #3268

Jogai opened this issue Jul 5, 2018 · 9 comments

Comments

@Jogai
Copy link

Jogai commented Jul 5, 2018

Bootstrap 3 contains a hack for ie8 (see https://github.com/twbs/bootstrap/blob/v3-dev/less/carousel.less#L204)

``background-color: #000 \9;

Less 3.5 on windows 10 gives this error:

../Content/Styles/Backend/Admin.less
111:13 error Module build failed (from ../node_modules/css-loader/index.js):
ModuleBuildError: Module build failed (from
// set alpha../node_modules/less-loader/dist/cjs.js):
background-color: #000cy for the best results possible.
inised input ^
c:\project\node_modules\bootstrap\less\carousel.less
(line 204, column 27) at runLoaders
(~\AppData\Roaming\npm\node_modules\webpack\lib\NormalModule.js:
at
~\AppData\Roaming\npm\node_modules\webpack\node_modules\loader-runner\lib\LoaderRunner.js:364:11

@matthew-dean
Copy link
Member

Does this compile on previous versions (3.0)?

@Jogai
Copy link
Author

Jogai commented Jul 5, 2018

Yes, I was at 3.0.4.

@matthew-dean
Copy link
Member

Confirmed. I tried to narrow down why one passes and the other doesn't, but I haven't been able to figure it out yet. I don't see where support for escaping currently (previously) happens in the parser.

@matthew-dean
Copy link
Member

@Jogai Please try latest release (v 3.5.2). Re-open if you still have an issue.

@aleen42
Copy link

aleen42 commented Jul 6, 2018

Fix quite fast, @matthew-dean well done 👍 .

@matthew-dean
Copy link
Member

@aleen42 Verified fixed for you?

@aleen42
Copy link

aleen42 commented Jul 6, 2018

@matthew-dean verified.!

@matthew-dean
Copy link
Member

@aleen42 Hooray! Sorry about the hiccup on this release!

@Jogai
Copy link
Author

Jogai commented Jul 6, 2018

Verified! Thanks for the fast response!

wmfgerrit pushed a commit to wikimedia/less.php that referenced this issue Jun 7, 2024
…13 behaviours

* Grid syntax (less/less.js#3092)
* Escapes in keywords (less/less.js#3268)

Bug: T288498
Change-Id: I3867cee77ad2a69ecb8e4f850fa5c548e3520b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants