Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedsd does not work with Pandas 2.0 #1834

Closed
edwardalee opened this issue Jun 9, 2023 · 0 comments · Fixed by #1836
Closed

fedsd does not work with Pandas 2.0 #1834

edwardalee opened this issue Jun 9, 2023 · 0 comments · Fixed by #1836
Assignees
Labels
bug Something isn't working federated

Comments

@edwardalee
Copy link
Collaborator

The fedsd utility for generating sequence diagrams fails with Pandas 2.0 with the following error:

Building the communication diagram for the following trace files: federate__c.lft federate__i.lft federate__t.lft rti.lft in trace_svg.html
Traceback (most recent call last):
  File "/Users/eal/lingua-franca-intellij/util/tracing/visualization/fedsd.py", line 137, in <module>
    trace_df = trace_df.append(fed_df, sort=False, ignore_index=True)
               ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pandas/core/generic.py", line 5989, in __getattr__
    return object.__getattribute__(self, name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

According to this page, append has been removed and must be replaced with concat.

@edwardalee edwardalee added bug Something isn't working federated labels Jun 9, 2023
ChadliaJerad added a commit that referenced this issue Jun 9, 2023
ChadliaJerad added a commit that referenced this issue Jun 14, 2023
ChadliaJerad added a commit that referenced this issue Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working federated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants