Fedsd compatibility with pandas 2.0 #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChadliaJerad
added
tracing
edwardalee
approved these changes
Jun 10, 2023
edwardalee
approved these changes
Jun 10, 2023
|
The failing C++ test seems the same as #1818. It is possible that the failing LSP test might have something to do with compiling in parallel such that the output gets interleaved and garbled. But I'm not sure, and this is awkward for me to reproduce since it seems like I do not have the same compiler on my system as is in CI. I'm also not sure what our policy should be when this happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1834.
It also makes
fedsdcorrectly match non-tagged messages, which enables the visualization of exchanged messages within physical connections.