Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Xtend classes to Java #838

Closed
36 tasks done
lhstrh opened this issue Jan 11, 2022 · 4 comments · Fixed by #853
Closed
36 tasks done

Port Xtend classes to Java #838

lhstrh opened this issue Jan 11, 2022 · 4 comments · Fixed by #853
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lhstrh
Copy link
Member

lhstrh commented Jan 11, 2022

We are well underway in our effort to port Xtend classes to Java. The following classes still need to be ported before we can cut our dependence on Xtend:

org.lflang.diagram package (@housengw)

  • org.lflang.diagram/src/org/lflang/diagram/synthesis/postprocessor/ReactionPortAdjustment.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/CycleVisualization.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/ReactorIcons.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/NamedInstanceUtil.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/UtilityExtensions.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/InterfaceDependenciesVisualization.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/util/SynthesisErrorReporter.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/SynthesisRegistration.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/LinguaFrancaSynthesis.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/styles/LinguaFrancaShapeExtensions.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/styles/LinguaFrancaStyleExtensions.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/AbstractSynthesisExtensions.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/MemorizingExpandCollapseAction.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/AbstractAction.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/FilterCycleAction.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/ShowCycleAction.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/CollapseAllReactorsAction.xtend
  • org.lflang.diagram/src/org/lflang/diagram/synthesis/action/ExpandAllReactorsAction.xtend

org.lflang.tests package (@lhstrh, @housengw)

  • org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaScopingTest.xtend
  • org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaValidationTest.xtend
  • org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaDependencyAnalysisTest.xtend
  • org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaASTUtilsTest.xtend
  • org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaParsingTest.xtend

org.lflang.ui package (@hokeun, @lhstrh)

  • org.lflang.ui/src/org/lflang/ui/wizard/LFProjectTemplateProvider.xtend
  • org.lflang.ui/src/org/lflang/ui/LFUiModuleImpl.xtend

org.lflang.federated package (@housengw)

  • org.lflang/src/org/lflang/federated/FederateInstance.xtend
  • org.lflang/src/org/lflang/federated/launcher/FedLauncher.xtend

org.lflang package (@housengw)

  • org.lflang/src/org/lflang/ASTUtils.xtend

org.lflang.generator package

  • org.lflang/src/org/lflang/generator/ReactionInstanceGraph.xtend
  • org.lflang/src/org/lflang/generator/GeneratorBase.xtend(@housengw)
  • org.lflang/src/org/lflang/generator/c/CGenerator.xtend (@housengw)
  • org.lflang/src/org/lflang/generator/InitializeRemoteTriggersTable.xtend (@hokeun)
  • org.lflang/src/org/lflang/generator/python/PythonGenerator.xtend (@housengw )

org.lflang.validation package @housengw

  • org.lflang/src/org/lflang/validation/LFValidator.xtend

org.lflang.graph package (@hokeun, @housengw)

  • org.lflang/src/org/lflang/graph/InstantiationGraph.xtend
  • org.lflang/src/org/lflang/graph/PrecedenceGraph.xtend
@lhstrh lhstrh added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 11, 2022
@hokeun
Copy link
Member

hokeun commented Jan 14, 2022

I'll work on ui package this weekend.

@hokeun hokeun self-assigned this Jan 14, 2022
@hokeun hokeun linked a pull request Jan 16, 2022 that will close this issue
@lhstrh lhstrh reopened this Jan 17, 2022
@hokeun
Copy link
Member

hokeun commented Jan 17, 2022

Ah, I just realized that an issue is automatically closed when the linked pull request is merged.

@housengw
Copy link
Contributor

since CGenerator.xtend has 6000+ lines, it might make sense to refactor it into smaller files first before porting it.

@housengw
Copy link
Contributor

housengw commented Mar 17, 2022

closing this issue as the last xtend file was ported to java in #1049

@lhstrh lhstrh removed this from the 0.2.0 milestone Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants