Ported PythonGenerator.xtend to Java and started refactoring of GeneratorBase
#958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soroosh129
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
The improvements to the PythonGenerator are excellent!
Thank you for taking up this task and turning it over so quickly.
I only had minor comments.
I still think that someone with a more experienced eye toward issues that could arise from porting Xtend to Java should probably also take a glance at the changes.
org.lflang/src/org/lflang/generator/python/PythonGenerator.java
Outdated
Show resolved
Hide resolved
lhstrh
approved these changes
Feb 25, 2022
lhstrh
changed the title
PythonGenerator.xtend to javaPythonGenerator.xtend to Java and started refactoring of GeneratorBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #838 for context.
Along with porting
PythonGeneratorto java, I also factored out part of the code into separate files (PythonReactionGenerator,PythonParameterGenerator, etc), which also led to factoring a small part ofCGeneratorinto separate files (CReactionGenerator)