Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CGenerator.xtend to Java #1049

Merged
merged 12 commits into from
Mar 17, 2022
Merged

Port CGenerator.xtend to Java #1049

merged 12 commits into from
Mar 17, 2022

Conversation

housengw
Copy link
Contributor

see #838

@housengw housengw marked this pull request as ready for review March 16, 2022 22:42
@housengw housengw requested a review from lhstrh March 17, 2022 00:34
Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Weirdly, build-lfc --clean was throwing the following error for me in this branch:
image

However, ./gradlew clean assemble fixed this error.

initializeTriggerObjects.pr("((self_base_t*)"+nameOfSelfStruct+")->_lf__mode_state.parent_mode = "+parentModeRef+";");
Iterable<ReactionInstance> reactionsOutsideModes = IterableExtensions.filter(instance.reactions, it -> it.getMode(true) == null);
for (ReactionInstance reaction : reactionsOutsideModes) {
initializeTriggerObjects.pr(CUtil.reactorRef(reaction.getParent())+"->_lf__reaction_"+instance.reactions.indexOf(reaction)+".mode = "+parentModeRef+";");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is slightly too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of time, I will merge this PR first and then refactor at some later time

@housengw housengw merged commit 94fd8a3 into master Mar 17, 2022
@housengw housengw mentioned this pull request Mar 17, 2022
36 tasks
@lhstrh lhstrh changed the title Port CGenerator.xtend to java Port CGenerator.xtend to Java Mar 17, 2022
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
@housengw housengw deleted the xtend-to-java-c-generator branch March 30, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants