Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary xtend-gen folder from classpath #1014

Merged
merged 5 commits into from
Mar 10, 2022

Conversation

soerendomroes
Copy link
Collaborator

There is no xtend in lignua franca, therefore, references to the xtend-gen folder can be safely removed.

@a-sr a-sr self-requested a review March 9, 2022 15:23
Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lhstrh This cleans up some xtend leftovers in the Eclipse configuration that are no longer necessary since all the xtend files in these projects were replaced by Java. A problem with these configurations only occurred in a fresh Oomph installation. @soerendomroes noticed this during a setup and fixed it right away. Thanks for that.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We should repeat these steps for the org.lflang package once #1011 has been completed.

@lhstrh
Copy link
Member

lhstrh commented Mar 9, 2022

Thanks for these fixes! I've enabled CI (which was necessary because this was your first PR); let's merge once the tests have passed.

@lhstrh lhstrh merged commit 6c6aa2f into lf-lang:master Mar 10, 2022
@lhstrh lhstrh changed the title Removed unnecessary xtend-gen folder from classpath. Removed unnecessary xtend-gen folder from classpath Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants