Keeplive natively inferred in the C++ runtime #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not do this for all targets? |
We should probably do it for all targets. But this of course requires support by the other runtimes and code generators. Also, I think there are still some open semantic questions. For instance, the behavior of timeout in the C target is influenced by the value of |
petervdonovan
approved these changes
Mar 9, 2023
lhstrh
approved these changes
Mar 10, 2023
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in lf-lang/reactor-cpp#42 which allows the C++ runtime to automatically infer if keepalive is needed. Consequently, the
keepalivetarget property in LF is disabled for the C++ target. If it is used anyway, a warning will be printed stating that the property is ignored.