Keep track of input actions in the environment #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the only action type that is an input action is a physical action. Later we will add enclave and federate connections.
cmnrd
added
enhancement
tanneberger
reviewed
Mar 9, 2023
| const bool fast_fwd_execution_{default_fast_fwd_execution}; | ||
|
|
||
| std::set<Reactor*> top_level_reactors_{}; | ||
| /// Set of actions that act as an input to the reactor program in this environment |
There was a problem hiding this comment.
Is this the set of physical actions then ?
There was a problem hiding this comment.
At the moment yes, but it will include enclave (and federated) connections soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows actions to be owned by the environment. It further adds the concept of 'input actions' which are actions that act as an input to the reactor program. Currently, this is limited to physical actions. Later, enclave and federate connections will be added. Since this mechanism allows us to infer if
keepaliveis needed or not, therun_foreverparameter of the Environment is dropped.