Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: adjust timeout for reuse garbage collector detection in tests #1487

Merged
merged 1 commit into from
May 16, 2022
Merged

quic: adjust timeout for reuse garbage collector detection in tests #1487

merged 1 commit into from
May 16, 2022

Conversation

marten-seemann
Copy link
Contributor

Fixes #1455.

@marten-seemann marten-seemann requested a review from MarcoPolo May 15, 2022 18:31
MarcoPolo
MarcoPolo approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is crazy that it takes over 100 ms to spin up a goroutine. This PR itself is fine.

I'm going to look into if we see the same flakiness on circleci.

@marten-seemann
Copy link
Contributor Author

This is crazy that it takes over 100 ms to spin up a goroutine.

I haven't dug into why this is a problem in this test but not the other tests, where we use 100ms without any problems. There might be more to it.

@marten-seemann marten-seemann merged commit a66dd00 into master May 16, 2022
@MarcoPolo MarcoPolo mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quic: flaky reuse tests
2 participants
@marten-seemann @MarcoPolo