Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a circle ci build that runs our test matrix for {Windows, macOS, Linux}⨯{go1.17,go1.18}.
I think we should merge this so we can see how the flakiness compares with GH Actions. Then later we can decide if we want to switch or not.
Some tests were skipped in this PR to minimize noise. Those tests are tracked here: #1505
Motivation
We've been seeing a lot of flakiness around timings in tests. Yes, generally relying on time in tests is not ideal, but there are somethings that should happen eventually. For example takes over 100ms to check if the GC is running.
If CircleCI saves us from having to deal with a lot of these flaky conditions it seems worth the switch. However if ipdx comes along with another solution I'm happy to switch to that as well. In the mean time I'd like to have us unblocked from flaky test land.