Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci project setup #1506

Closed
wants to merge 1 commit into from
Closed

Circleci project setup #1506

wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented May 18, 2022

This adds a circle ci build that runs our test matrix for {Windows, macOS, Linux}⨯{go1.17,go1.18}.

I think we should merge this so we can see how the flakiness compares with GH Actions. Then later we can decide if we want to switch or not.

Some tests were skipped in this PR to minimize noise. Those tests are tracked here: #1505

Motivation

We've been seeing a lot of flakiness around timings in tests. Yes, generally relying on time in tests is not ideal, but there are somethings that should happen eventually. For example takes over 100ms to check if the GC is running.

If CircleCI saves us from having to deal with a lot of these flaky conditions it seems worth the switch. However if ipdx comes along with another solution I'm happy to switch to that as well. In the mean time I'd like to have us unblocked from flaky test land.

@MarcoPolo MarcoPolo requested a review from marten-seemann May 18, 2022 16:49
@MarcoPolo MarcoPolo force-pushed the circleci-project-setup branch from ff4c9cf to c1f72de Compare May 18, 2022 18:14
@MarcoPolo
Copy link
Collaborator Author

It would be nice to include this in linux: sysctl -w net.core.rmem_max=2500000 to increase the udp recv buffer size. Easy change, but can do it in another PR if this gets reviewed before I make that change.

@MarcoPolo MarcoPolo force-pushed the circleci-project-setup branch from c1f72de to 44b6562 Compare May 19, 2022 00:20
@MarcoPolo
Copy link
Collaborator Author

closing this since I'm less convinced circle CI is less flaky than GH actions. A rough count of 30 runs on this branch found around 7 failed. We can reopen this if needed. For now I'm going to focus on making our tests less flaky to start with.

@MarcoPolo MarcoPolo closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant