Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub messages not delivered in [email protected] #2004

Closed
sneaker1 opened this issue Aug 30, 2023 · 2 comments · Fixed by #1785
Closed

Pubsub messages not delivered in [email protected] #2004

sneaker1 opened this issue Aug 30, 2023 · 2 comments · Fixed by #1785
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@sneaker1
Copy link
Contributor

  • Version:
    "libp2p": "^0.46.7",
    "@libp2p/floodsub": "^8.0.6",
    "@chainsafe/libp2p-gossipsub": "^10.1.0",

  • Platform:
    Linux

  • Subsystem:
    Pubsub

Severity:

High - The main functionality of the application does not work, API breakage, repo format breakage, etc.

Description:

Since libp2p version 0.46.7 i am having problems with pubsub messages not being delivered in my application.
I normally use gossipsub, but i also have the problem with floodsub.
I have tested it on a setup with only 2 nodes involved. Both are on different publicly dialable servers on the internet.



With gossipsub i get the following debug error on the publisher side when sending a message:

  libp2p:gossipsub:error Error: The operation was aborted
  libp2p:gossipsub:error     at nextAbortHandler (file:///home/celo/coding/libp2pProj/server/node_modules/abortable-iterator/dist/src/index.js:71:32)
  libp2p:gossipsub:error     at AbortSignal.abortHandler (file:///home/celo/coding/libp2pProj/server/node_modules/abortable-iterator/dist/src/index.js:58:17)
  libp2p:gossipsub:error     at AbortSignal.[nodejs.internal.kHybridDispatch] (node:internal/event_target:736:20)
  libp2p:gossipsub:error     at AbortSignal.dispatchEvent (node:internal/event_target:678:26)
  libp2p:gossipsub:error     at abortSignal (node:internal/abort_controller:292:10)
  libp2p:gossipsub:error     at Timeout._onTimeout (node:internal/abort_controller:112:7)
  libp2p:gossipsub:error     at listOnTimeout (node:internal/timers:559:17)
  libp2p:gossipsub:error     at processTimers (node:internal/timers:502:7) +0ms
  libp2p:gossipsub connection ended QmSjtK2Xp9FuLXwn3KYdv7pUcjaTr6QQkMChUmDySkasvA +986ms
  libp2p:gossipsub delete peer QmSjtK2Xp9FuLXwn3KYdv7pUcjaTr6QQkMChUmDySkasvA +0ms

On the other side nothing is received.



With floodsub, after bootup of the nodes one message gets send and received, but no further messages.
I have attached the debug output from the sender side and the receiver side.
You can see the first message on topic newOffer successfully being delivered. The following messages are sent but not received on the other side.

Regards Sneaker
Floodsub_Receiver.txt
Floodsub_Sender.txt

@sneaker1 sneaker1 added the need/triage Needs initial labeling and prioritization label Aug 30, 2023
@sneaker1
Copy link
Contributor Author

I have done further investigation and found out that commit #1988 caused the issue.
After reversing the changes from this commit, my application delivered the pubsub messages as expected.

@marcus-pousette
Copy link
Contributor

#2020 I have the same issue 0.46.7 and up is broken 0.46.6 works

@maschad maschad self-assigned this Sep 4, 2023
@maschad maschad added kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Sep 4, 2023
@maschad maschad added this to js-libp2p Sep 4, 2023
@maschad maschad moved this to 🏃‍♀️In Progress in js-libp2p Sep 4, 2023
achingbrain added a commit that referenced this issue Sep 5, 2023
Replaces abortable-iterator with a simple abort signal listener that just aborts the stream.

Closes #2001
Closes #2004
Closes #2020

---------

Co-authored-by: chad <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏃‍♀️In Progress to 🎉Done in js-libp2p Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants