refactor(libp2p): remove unnecessary any-signal #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of `any-signal` where we only have one signal.
maschad
changed the title
maschad
changed the title
maschad
changed the title
maschad
changed the title
|
Thanks for updating the tag used in the commit message. For this project the permissible tags are found in the main.yml GH actions file. "refactor" isn't in there so it either needs to be added or an existing one chosen, perhaps "chore"? |
|
Good spot @achingbrain , perhaps we can merge #1990 first then this. |
SgtPooki
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of
any-signalwhere we only have one signal.