Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapdb: properly set max connections for postgres #336

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Jun 1, 2023

The default is unlimited, means that with the default postgres limit of 100, you'll run into errors.

@Roasbeef Roasbeef force-pushed the postgres-max-conns branch from 57cf435 to fd65ab5 Compare June 1, 2023 17:59
@Roasbeef Roasbeef requested a review from guggero June 1, 2023 17:59
@jharveyb
Copy link
Contributor

jharveyb commented Jun 1, 2023

Stray migrations / tables?

The default is unlimited, means that with the default postgres limit of
100, you'll run into errors.
@Roasbeef Roasbeef force-pushed the postgres-max-conns branch from fd65ab5 to 78c1562 Compare June 1, 2023 19:57
@Roasbeef
Copy link
Member Author

Roasbeef commented Jun 1, 2023

@jharveyb fixed!

@guggero guggero requested a review from jharveyb June 2, 2023 06:56
@jharveyb
Copy link
Contributor

jharveyb commented Jun 5, 2023

Tested with #334, and confirmed these change fix the proof upload issues we observed before.

@jharveyb jharveyb added this pull request to the merge queue Jun 5, 2023
Merged via the queue into lightninglabs:main with commit b52587e Jun 5, 2023
@dstadulis
Copy link
Collaborator

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants