Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't just source lima.env; value might include spaces #98

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

jandubois
Copy link
Member

Instead copy the code from Lima's boot.sh.

This is required to fix lima-vm/lima#933

Instead copy the code from Lima's boot.sh.

This is required to fix lima-vm/lima#933

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois requested a review from a team February 11, 2023 04:58
jandubois added a commit to jandubois/sshocker that referenced this pull request Feb 11, 2023
This is required because the names are sent as a single string over ssh.

This (together with lima-vm/alpine-lima#98)
will fix lima-vm/lima#933.

Signed-off-by: Jan Dubois <[email protected]>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 3fc0281 into lima-vm:main Feb 11, 2023
@jandubois jandubois deleted the spaces branch February 11, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mountpoints cannot include whitespace
2 participants