Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mountpoints cannot include whitespace #933

Closed
jandubois opened this issue Jun 29, 2022 · 0 comments · Fixed by lima-vm/alpine-lima#98 or lima-vm/sshocker#64
Closed

Mountpoints cannot include whitespace #933

jandubois opened this issue Jun 29, 2022 · 0 comments · Fixed by lima-vm/alpine-lima#98 or lima-vm/sshocker#64
Labels
bug Something isn't working expert

Comments

@jandubois
Copy link
Member

Description

Lima does not support mounting locations containing whitespace, e.g.

mounts:
- location: "~/foo bar"
  writable: true

This obviously affects users whose host username contains a space.

Known problem spots:

  • lima.env does not quote LIMA_CIDATA_MOUNTS_NNN_MOUNTPOINT
  • reversesshfs.Prepare doesn't quote the argument to mkdir -p
  • reversesshfs.Start doesn't quote the local and remote path arguments to sshfs

There are probably more...
@AkihiroSuda AkihiroSuda added bug Something isn't working expert labels Jun 30, 2022
jandubois added a commit to rancher-sandbox/alpine-lima that referenced this issue Feb 11, 2023
@jandubois
Don't just source lima.env; value might include spaces
34b03da 
Instead copy the code from Lima's boot.sh.

This is required to fix lima-vm/lima#933

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois mentioned this issue Feb 11, 2023
Merged
jandubois added a commit to jandubois/sshocker that referenced this issue Feb 11, 2023
@jandubois
Quote local and remote filenames in case they include spaces
7ed7e03 
This is required because the names are sent as a single string over ssh.

This (together with lima-vm/alpine-lima#98)
will fix lima-vm/lima#933.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois mentioned this issue Feb 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working expert
Projects
None yet
Milestone
No milestone
2 participants
@jandubois @AkihiroSuda