Increase level range to 999 (9.99) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987123879113
commented
Sep 28, 2020
| @@ -423,7 +423,7 @@ private void InitializeComponent() | |||
| // hScrollBarBLEVEL | |||
| // | |||
| resources.ApplyResources( this.hScrollBarBLEVEL, "hScrollBarBLEVEL" ); | |||
| this.hScrollBarBLEVEL.Maximum = 109; | |||
| this.hScrollBarBLEVEL.Maximum = 999 + 9; | |||
There was a problem hiding this comment.
For some reason all maximum values need to be +9. It's a result of a bug somewhere but I have no idea why.
|
Sorry @987123879113 due to my big PR #59 your PR has conflict. I would recommend getting a fresh clone and redoing your change on the new codebase. |
ericpignet
referenced
this pull request
in ericpignet/DTXmaniaNX
Sep 29, 2020
ericpignet
added a commit
that referenced
this pull request
Sep 29, 2020
|
I didn't test the change but code looks good and safe, many thanks Nagato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drum level is being defaulted to 50 (https://github.com/limyz/DTXmaniaNX/blob/master/DTXCreatorProject/Code/00.App/CMainForm.cs#L523,L526), but the value will not be cleared/set to 0 if you load a DTX file without a drum chart. So make sure all difficulty levels are set to 0 when loading a new DTX file.
Increase the range from 0 - 100 to 0 - 999 (9.99) to make it possible to load charts with Gitadora-style levels without crashing.