[server] Validate block-cache config against system memory #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-nagarajan
reviewed
Feb 6, 2025
...nci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBStorageEngineFactory.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBServerConfig.java
Outdated
Show resolved
Hide resolved
gaojieliu
reviewed
Feb 6, 2025
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBServerConfig.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBServerConfig.java
Outdated
Show resolved
Hide resolved
...nci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBStorageEngineFactory.java
Outdated
Show resolved
Hide resolved
gaojieliu
reviewed
Feb 7, 2025
...nci-client/src/main/java/com/linkedin/davinci/store/rocksdb/RocksDBStorageEngineFactory.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Show resolved
Hide resolved
majisourav99
force-pushed
the
cfgCheck
branch
from
b5cde84 to
70246a3
Compare
added 6 commits
February 11, 2025 10:49
majisourav99
force-pushed
the
cfgCheck
branch
from
70246a3 to
7c673ea
Compare
added 3 commits
February 11, 2025 12:11
gaojieliu
reviewed
Feb 12, 2025
...mmon/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceServerWrapper.java
Outdated
Show resolved
Hide resolved
added 3 commits
February 12, 2025 10:05
gaojieliu
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate block-cache config against system memory
If operator deploys config with exceeds system resource limits, it makes the cluster into inoperable state and finally destroys the cluster. This PR fails rolling out such config for blockcache.
How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?