Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Validate block-cache config against system memory #1508

Merged
merged 12 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ public class RocksDBServerConfig {
"rocksdb.blob.garbage.collection.force.threshold";
public static final String ROCKSDB_BLOB_FILE_STARTING_LEVEL = "rocksdb.blob.file.starting.level";

public static final String ROCKSDB_BLOCK_CACHE_MEMORY_LIMIT = "rocksdb.block.cache.memory.limit";

private final boolean rocksDBUseDirectReads;

private final int rocksDBEnvFlushPoolSize;
Expand Down Expand Up @@ -312,6 +314,7 @@ public class RocksDBServerConfig {
private final double blobGarbageCollectionAgeCutOff;
private final double blobGarbageCollectionForceThreshold;
private final int blobFileStartingLevel;
private final double rocksdbBlockCacheMemoryLimit;

public RocksDBServerConfig(VeniceProperties props) {
// Do not use Direct IO for reads by default
Expand Down Expand Up @@ -450,6 +453,7 @@ public RocksDBServerConfig(VeniceProperties props) {
this.blobGarbageCollectionAgeCutOff = props.getDouble(ROCKSDB_BLOB_GARBAGE_COLLECTION_AGE_CUTOFF, 0.25);
this.blobGarbageCollectionForceThreshold = props.getDouble(ROCKSDB_BLOB_GARBAGE_COLLECTION_FORCE_THRESHOLD, 0.8);
this.blobFileStartingLevel = props.getInt(ROCKSDB_BLOB_FILE_STARTING_LEVEL, 0);
this.rocksdbBlockCacheMemoryLimit = props.getDouble(ROCKSDB_BLOCK_CACHE_MEMORY_LIMIT, 0.8);
}

public int getLevel0FileNumCompactionTriggerWriteOnlyVersion() {
Expand Down Expand Up @@ -686,4 +690,8 @@ public double getBlobGarbageCollectionForceThreshold() {
public int getBlobFileStartingLevel() {
return blobFileStartingLevel;
}

public double getRocksdbBlockCacheMemoryLimit() {
return rocksdbBlockCacheMemoryLimit;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.linkedin.davinci.store.rocksdb;

import static com.linkedin.venice.utils.ByteUtils.generateHumanReadableByteCountString;
import static com.linkedin.venice.utils.Utils.getOSMemorySize;
import static org.rocksdb.RateLimiter.DEFAULT_FAIRNESS;
import static org.rocksdb.RateLimiter.DEFAULT_MODE;
import static org.rocksdb.RateLimiter.DEFAULT_REFILL_PERIOD_MICROS;
Expand Down Expand Up @@ -139,6 +141,19 @@ public RocksDBStorageEngineFactory(
this.env.setBackgroundThreads(rocksDBServerConfig.getRocksDBEnvFlushPoolSize(), Priority.HIGH);
this.env.setBackgroundThreads(rocksDBServerConfig.getRocksDBEnvCompactionPoolSize(), Priority.LOW);

long cacheBytesNeeded =
rocksDBServerConfig.getRocksDBBlockCacheSizeInBytes() + (rocksDBServerConfig.isUseSeparateRMDCacheEnabled()
? rocksDBServerConfig.getRocksDBRMDBlockCacheSizeInBytes()
: 0);

long systemMemorySize = getOSMemorySize();
if (systemMemorySize > 0
&& (systemMemorySize * rocksDBServerConfig.getRocksdbBlockCacheMemoryLimit() < cacheBytesNeeded)) {
throw new RuntimeException(
"Cannot setup rocksdb instance with block-cache size "
+ generateHumanReadableByteCountString(cacheBytesNeeded) + ". System memory : "
+ generateHumanReadableByteCountString(systemMemorySize));
}
// Shared cache across all the RocksDB databases
if (RocksDBBlockCacheImplementations.CLOCK.equals(rocksDBServerConfig.getRocksDBBlockCacheImplementation())) {
if (rocksDBServerConfig.isUseSeparateRMDCacheEnabled()) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.linkedin.davinci.store.rocksdb;

Check failure on line 1 in clients/da-vinci-client/src/test/java/com/linkedin/davinci/store/rocksdb/ReplicationMeadataRocksDBStoragePartitionCFTest.java

View workflow job for this annotation

GitHub Actions / Server / UT & CodeCov (8)

ReplicationMeadataRocksDBStoragePartitionCFTest.testMetadataColumnFamily

java.lang.RuntimeException: Cannot setup rocksdb instance with block-cache size 16.0 GiB. System memory : 15.6 GiB

Check failure on line 1 in clients/da-vinci-client/src/test/java/com/linkedin/davinci/store/rocksdb/ReplicationMeadataRocksDBStoragePartitionCFTest.java

View workflow job for this annotation

GitHub Actions / Server / UT & CodeCov (8)

ReplicationMeadataRocksDBStoragePartitionCFTest.testReplicationMetadataIngestion[0](true, false, false, true)

java.lang.RuntimeException: Cannot setup rocksdb instance with block-cache size 16.0 GiB. System memory : 15.6 GiB

Check failure on line 1 in clients/da-vinci-client/src/test/java/com/linkedin/davinci/store/rocksdb/ReplicationMeadataRocksDBStoragePartitionCFTest.java

View workflow job for this annotation

GitHub Actions / Server / UT & CodeCov (8)

ReplicationMeadataRocksDBStoragePartitionCFTest.testReplicationMetadataIngestion[1](true, false, false, false)

java.lang.RuntimeException: Cannot setup rocksdb instance with block-cache size 16.0 GiB. System memory : 15.6 GiB

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_RMD_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_SEPARATE_RMD_CACHE_ENABLED;
import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.ArgumentMatchers.anyString;
Expand Down Expand Up @@ -49,6 +51,8 @@

Properties properties = new Properties();
properties.put(ROCKSDB_SEPARATE_RMD_CACHE_ENABLED, "true");
properties.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 1024 * 1024 * 1024L);
properties.put(ROCKSDB_RMD_BLOCK_CACHE_SIZE_IN_BYTES, 1024 * 1024L);
VeniceProperties serverProps = AbstractStorageEngineTest.getServerProperties(PersistenceType.ROCKS_DB, properties);
storageService = new StorageService(
AbstractStorageEngineTest.getVeniceConfigLoader(serverProps),
Expand Down
1 change: 1 addition & 0 deletions docker/venice-server/single-dc-configs/server.properties
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ system.schema.cluster.name=venice-cluster0
data.base.path=/opt/venice/rocksdb
server.ingestion.isolation.application.port=54094
persistence.type=ROCKS_DB
rocksdb.block.cache.size.in.bytes=2147483648
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
import static com.linkedin.venice.ConfigKeys.CLIENT_USE_SYSTEM_STORE_REPOSITORY;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -271,6 +272,7 @@ public VeniceProperties buildRecordTransformerBackendConfig(boolean pushStatusSt
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(DA_VINCI_CURRENT_VERSION_BOOTSTRAPPING_SPEEDUP_ENABLED, true)
.put(PUSH_STATUS_STORE_ENABLED, pushStatusStoreEnabled)
.put(DAVINCI_PUSH_STATUS_CHECK_INTERVAL_IN_MS, 1000);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.lang.management.ManagementFactory;
import java.lang.management.OperatingSystemMXBean;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.nio.file.Files;
Expand Down Expand Up @@ -1141,4 +1142,16 @@ public static long parseDateTimeToEpoch(String dateTime, String dateTimeFormat,
dateFormat.setTimeZone(TimeZone.getTimeZone(timeZone));
return dateFormat.parse(dateTime).getTime();
}

public static long getOSMemorySize() {
OperatingSystemMXBean osBean = ManagementFactory.getOperatingSystemMXBean();

if (osBean instanceof com.sun.management.OperatingSystemMXBean) {
com.sun.management.OperatingSystemMXBean extendedOsBean = (com.sun.management.OperatingSystemMXBean) osBean;
majisourav99 marked this conversation as resolved.
Show resolved Hide resolved
return extendedOsBean.getTotalPhysicalMemorySize();
} else {
System.out.println("OS Bean not available.");
}
return -1;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED;
import static com.linkedin.venice.CommonConfigKeys.SSL_ENABLED;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -480,8 +481,10 @@ public void testAAReplicationCanConsumeFromAllRegions(boolean isChunkingEnabled,

// Verify that DaVinci client can successfully bootstrap all partitions from AA enabled stores
String baseDataPath = Utils.getTempDataDirectory().getAbsolutePath();
VeniceProperties backendConfig =
new PropertyBuilder().put(DATA_BASE_PATH, baseDataPath).put(PERSISTENCE_TYPE, ROCKS_DB).build();
VeniceProperties backendConfig = new PropertyBuilder().put(DATA_BASE_PATH, baseDataPath)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

MetricsRepository metricsRepository = new MetricsRepository();
try (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
import static com.linkedin.venice.ConfigKeys.CLIENT_USE_SYSTEM_STORE_REPOSITORY;
import static com.linkedin.venice.ConfigKeys.CLUSTER_DISCOVERY_D2_SERVICE;
Expand Down Expand Up @@ -142,6 +143,7 @@ private VeniceProperties getDaVinciBackendConfig(boolean useDaVinciSpecificExecu
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(D2_ZK_HOSTS_ADDRESS, venice.getZk().getAddress())
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(CLUSTER_DISCOVERY_D2_SERVICE, VeniceRouterWrapper.CLUSTER_DISCOVERY_D2_SERVICE_NAME)
.put(USE_DA_VINCI_SPECIFIC_EXECUTION_STATUS_FOR_ERROR, useDaVinciSpecificExecutionStatusForError)
.put(SERVER_DISK_FULL_THRESHOLD, getDiskFullThreshold(largePushRecordCount, largePushRecordMinSize));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_MEMTABLE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_TOTAL_MEMTABLE_USAGE_CAP_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
Expand Down Expand Up @@ -143,6 +144,7 @@ private VeniceProperties getDaVinciBackendConfig(
.put(D2_ZK_HOSTS_ADDRESS, veniceCluster.getZk().getAddress())
.put(CLUSTER_DISCOVERY_D2_SERVICE, VeniceRouterWrapper.CLUSTER_DISCOVERY_D2_SERVICE_NAME)
.put(ROCKSDB_MEMTABLE_SIZE_IN_BYTES, "2MB")
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 4 * 1024 * 1024L)
.put(ROCKSDB_TOTAL_MEMTABLE_USAGE_CAP_IN_BYTES, "10MB")
.put(INGESTION_MEMORY_LIMIT_STORE_LIST, String.join(",", memoryLimitStores))
.put(USE_DA_VINCI_SPECIFIC_EXECUTION_STATUS_FOR_ERROR, useDaVinciSpecificExecutionStatusForError);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED;
import static com.linkedin.venice.ConfigKeys.BLOB_TRANSFER_MANAGER_ENABLED;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
Expand Down Expand Up @@ -756,6 +757,7 @@ public VeniceProperties buildRecordTransformerBackendConfig(boolean pushStatusSt
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(DA_VINCI_CURRENT_VERSION_BOOTSTRAPPING_SPEEDUP_ENABLED, true);

if (pushStatusStoreEnabled) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED;
import static com.linkedin.venice.ConfigKeys.BLOB_TRANSFER_MANAGER_ENABLED;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
Expand Down Expand Up @@ -193,6 +194,7 @@ public void testConcurrentGetAndStart() throws Exception {
VeniceProperties backendConfig = new PropertyBuilder().put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down Expand Up @@ -261,6 +263,7 @@ public void testBatchStore(DaVinciConfig clientConfig) throws Exception {
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(DA_VINCI_CURRENT_VERSION_BOOTSTRAPPING_SPEEDUP_ENABLED, true)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(DAVINCI_PUSH_STATUS_CHECK_INTERVAL_IN_MS, 1000)
Expand Down Expand Up @@ -381,6 +384,7 @@ public void testIncrementalPushStatusBatching(boolean isIngestionIsolated) throw
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, Utils.getTempDataDirectory().getAbsolutePath())
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(DAVINCI_PUSH_STATUS_CHECK_INTERVAL_IN_MS, 1000)
.build();
Expand Down Expand Up @@ -458,6 +462,7 @@ public void testObjectReuse(DaVinciConfig clientConfig) throws Exception {
// TODO: Looks like cache = null does not work with fast meta store repository refresh interval
// .put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down Expand Up @@ -710,6 +715,7 @@ public void testHybridStoreWithoutIngestionIsolation(DaVinciConfig daVinciConfig
VeniceProperties backendConfig = new PropertyBuilder().put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, Utils.getTempDataDirectory().getAbsolutePath())
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down Expand Up @@ -774,6 +780,7 @@ public void testHybridStore() throws Exception {
VeniceProperties backendConfig = new PropertyBuilder().put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, Utils.getTempDataDirectory().getAbsolutePath())
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down Expand Up @@ -1003,6 +1010,7 @@ public void testBootstrapSubscription(DaVinciConfig daVinciConfig) throws Except
.put(DA_VINCI_CURRENT_VERSION_BOOTSTRAPPING_SPEEDUP_ENABLED, true)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(DAVINCI_PUSH_STATUS_CHECK_INTERVAL_IN_MS, 1000)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(DA_VINCI_SUBSCRIBE_ON_DISK_PARTITIONS_AUTOMATICALLY, false)
.build();

Expand Down Expand Up @@ -1064,7 +1072,8 @@ public void testBootstrapSubscription(DaVinciConfig daVinciConfig) throws Except
@Test(timeOut = TEST_TIMEOUT, dataProvider = "dv-client-config-provider", dataProviderClass = DataProviderUtils.class)
public void testPartialSubscription(DaVinciConfig daVinciConfig) throws Exception {
String storeName = createStoreWithMetaSystemStoreAndPushStatusSystemStore(KEY_COUNT);
VeniceProperties backendConfig = new PropertyBuilder().build();
VeniceProperties backendConfig =
new PropertyBuilder().put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L).build();

Set<Integer> keySet = new HashSet<>();
for (int i = 0; i < KEY_COUNT; ++i) {
Expand Down Expand Up @@ -1187,6 +1196,7 @@ public void testCrashedDaVinciWithIngestionIsolation() throws Exception {
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(D2_ZK_HOSTS_ADDRESS, zkHosts)
.build();

Expand Down Expand Up @@ -1265,6 +1275,7 @@ public void testBlobP2PTransferAmongDVC() throws Exception {
.put(DAVINCI_P2P_BLOB_TRANSFER_SERVER_PORT, port2)
.put(DAVINCI_P2P_BLOB_TRANSFER_CLIENT_PORT, port1)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(DAVINCI_PUSH_STATUS_SCAN_INTERVAL_IN_SECONDS, 1)
.put(BLOB_TRANSFER_MANAGER_ENABLED, true);
VeniceProperties backendConfig2 = configBuilder.build();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
import static com.linkedin.venice.ConfigKeys.CLIENT_USE_SYSTEM_STORE_REPOSITORY;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -166,6 +167,7 @@ public void testMultiClusterDaVinci() throws Exception {
new PropertyBuilder().put(DATA_BASE_PATH, Utils.getTempDataDirectory().getAbsolutePath())
.put(PERSISTENCE_TYPE, PersistenceType.ROCKS_DB)
.put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.build();
DaVinciConfig daVinciConfig = new DaVinciConfig();
Expand Down Expand Up @@ -320,6 +322,7 @@ public void testDaVinciVersionSwap() throws Exception {
new PropertyBuilder().put(DATA_BASE_PATH, Utils.getTempDataDirectory().getAbsolutePath())
.put(PERSISTENCE_TYPE, PersistenceType.ROCKS_DB)
.put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.build();
D2Client daVinciD2 = D2TestUtils.getAndStartD2Client(multiClusterVenice.getZkServerWrapper().getAddress());
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
import static com.linkedin.venice.ConfigKeys.CLIENT_USE_SYSTEM_STORE_REPOSITORY;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -659,6 +660,7 @@ public void testPartialKeyLookupWithRocksDBBlockBasedTable() throws ExecutionExc
VeniceProperties backendConfig = new PropertyBuilder().put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down Expand Up @@ -760,6 +762,7 @@ public void testPartialKeyLookupWithRocksDBPlainTable() throws ExecutionExceptio
VeniceProperties backendConfig = new PropertyBuilder().put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(DATA_BASE_PATH, baseDataPath)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(PERSISTENCE_TYPE, ROCKS_DB)
.build();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.endToEnd;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES;
import static com.linkedin.venice.ConfigKeys.CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS;
import static com.linkedin.venice.ConfigKeys.CLIENT_USE_SYSTEM_STORE_REPOSITORY;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -164,6 +165,7 @@ public void testBatchReportIncrementalPush() throws IOException {
.put(CLIENT_USE_SYSTEM_STORE_REPOSITORY, true)
.put(CLIENT_SYSTEM_STORE_REPOSITORY_REFRESH_INTERVAL_SECONDS, 1)
.put(PUSH_STATUS_STORE_ENABLED, true)
.put(ROCKSDB_BLOCK_CACHE_SIZE_IN_BYTES, 2 * 1024 * 1024L)
.put(SERVER_BATCH_REPORT_END_OF_INCREMENTAL_PUSH_STATUS_ENABLED, true)
.put(DAVINCI_PUSH_STATUS_SCAN_INTERVAL_IN_SECONDS, 1)
.build();
Expand Down
Loading
Loading