Chore: Enable local storage for MSW feature flags #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
chore-enable-ff-local-storage
branch
from
2eca43f to
3b65f05
Compare
mjac0bs
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Confirming flags persisted on refresh and cleared once I cleared my local storage. Thank you.
(I imagine this was the intent/functional at some point in the past, right?)
bnussman-akamai
added
Add'tl Approval Needed
|
@mjac0bs not sure but certainly should have |
hana-akamai
approved these changes
Jul 13, 2023
bnussman-akamai
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super tiny PR to persist our MSW flag choices via local storage.
Testing
Enable an MSW flag and reload the page.