fix: Make feature flag dev tools show reality #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
:1 nice thx for fixing but really against reverting #9400, the developer experience was improved and the tradeoff is you keeping track of your flags.
However, if important to you, we could add a "Don't store flags" checkbox to trigger logic in the useEffect to keep LDs defaults and prevent setting flags in local storage so we really only store that noFlags option in storage. This way we can both be happy :)
bnussman-akamai
added
Add'tl Approval Needed
dwiley-akamai
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
While we're here we might as well get rid of L16 to more accurately reflect what's actually feature flagged currently
bnussman-akamai
added
Approved
|
Good idea about |
bnussman-akamai
added a commit
to bnussman-akamai/manager
that referenced
this pull request
Aug 22, 2023
* make dev tools match real life * Added changeset: Make feature flag dev tools show reality * fix import order * clean up flags --------- Co-authored-by: Banks Nussman <[email protected]>
This was referenced Sep 5, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* make dev tools match real life * Added changeset: Make feature flag dev tools show reality * fix import order * clean up flags --------- Co-authored-by: Banks Nussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪