Handle Windows drive letter in Mix runtime path in the CLI #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jun 24, 2022
| @@ -343,6 +343,15 @@ defmodule Livebook.Config do | |||
|
|
|||
| defp parse_mix_config!(config) do | |||
| case String.split(config, ":", parts: 2) do | |||
| # Ignore Windows drive letter | |||
There was a problem hiding this comment.
Can we add a unit test to Livebook.Config.default_runtime! that tests this? :)
There was a problem hiding this comment.
Actually it's tricky because we check if the path is an actual mix project, which we can't simulate this on linux (i.e. a path with the drive letter), and in case of errors we use System.halt which would make the tests pass. We could raise and do System.halt upstream, but it's not particularly convenient 🤔
josevalim
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1228.