Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Windows drive letter in Mix runtime path in the CLI #1242

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Handle Windows drive letter in Mix runtime path in the CLI #1242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/livebook/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,15 @@ defmodule Livebook.Config do

defp parse_mix_config!(config) do
case String.split(config, ":", parts: 2) do
# Ignore Windows drive letter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test to Livebook.Config.default_runtime! that tests this? :)

Copy link
Member Author

@jonatanklosko jonatanklosko Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's tricky because we check if the path is an actual mix project, which we can't simulate this on linux (i.e. a path with the drive letter), and in case of errors we use System.halt which would make the tests pass. We could raise and do System.halt upstream, but it's not particularly convenient 🤔

[<<letter>>, rest] when letter in ?a..?z or letter in ?A..?Z ->
[path | rest] = String.split(rest, ":", parts: 2)
[<<letter, ":", path::binary>> | rest]

other ->
other
end
|> case do
[path] -> {path, ""}
[path, flags] -> {path, flags}
end
Expand Down