#75 MatcherEnvelope for TypeSafeMatcher #87

borysfan · 2019-01-21T20:12:13Z

This PR is for #75:

Introduce wrapper (MatcherEnvelope) for hamcrest TypeSafeMatcher
Input should inherit from MatcherEnvelope

0crat · 2019-01-21T20:12:54Z

Job #87 is now in scope, role is REV

codecov · 2019-01-21T20:15:39Z

Codecov Report

Merging #87 into master will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
+ Coverage     91.73%   92.74%   +1%     
- Complexity       82       89    +7     
=========================================
  Files            20       21    +1     
  Lines           230      248   +18     
  Branches          3        3           
=========================================
+ Hits            211      230   +19     
+ Misses           17       16    -1     
  Partials          2        2

Impacted Files	Coverage Δ	Complexity Δ
...rg/llorllale/cactoos/matchers/MatcherEnvelope.java	`100% <100%> (ø)`	`5 <5> (?)`
...rg/llorllale/cactoos/matchers/InputHasContent.java	`100% <100%> (+25%)`	`7 <6> (+3)`	⬆️
...java/org/llorllale/cactoos/matchers/MatcherOf.java	`63.63% <0%> (-18.19%)`	`3% <0%> (-1%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e2fb9...8dde23a. Read the comment docs.

0crat · 2019-01-21T20:18:56Z

This pull request #87 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

fabriciofx · 2019-01-21T20:25:26Z

@borysfan Please, fix this PR title and the explanation what you did on it.

fabriciofx

@borysfan Done. Please, check out.

src/main/java/org/llorllale/cactoos/matchers/InputHasContent.java

src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java

src/main/java/org/llorllale/cactoos/matchers/ScalarHasValue.java

fabriciofx

@borysfan Done. Check out again.

src/main/java/org/llorllale/cactoos/matchers/InputHasContent.java

src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java

src/test/java/org/llorllale/cactoos/matchers/InputHasContentTest.java

fabriciofx · 2019-01-23T01:02:54Z

@borysfan Please, change the commit messages. Look at the repo to see the pattern. Sorry, but I won't accept the PR if the commit messages not follow the pattern. And (again): change PR content too. You can see others PR to see the patterns.

fabriciofx · 2019-01-24T14:33:50Z

@borysfan ping

fabriciofx · 2019-01-26T22:28:34Z

@borysfan ping

…adoc. Test case for fail situation

borysfan · 2019-01-27T13:44:23Z

@fabriciofx I've resolved all your comments.

fabriciofx · 2019-01-27T14:14:43Z

@borysfan This PR seems fine to me. Congratulations!

fabriciofx · 2019-01-27T14:14:50Z

@rultor merge

rultor · 2019-01-27T14:15:40Z

@rultor merge

@fabriciofx Thanks for your request. @llorllale Please confirm this.

llorllale · 2019-01-27T15:54:45Z

src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java

+import org.hamcrest.TypeSafeMatcher;
+
+/**
+ * A wrapper class for {@link TypeSafeMatcher}.


@borysfan just "Matcher Envelope"

@llorllale Changed.

llorllale · 2019-01-27T15:57:23Z

@borysfan left you a minor comment.

Also, please leave a puzzle for refactoring other matchers to extend this envelope.

borysfan · 2019-01-27T18:13:53Z

@llorllale New puzzle has been added.

llorllale · 2019-01-27T19:47:17Z

@rultor merge

rultor · 2019-01-27T19:47:36Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-27T19:50:57Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 3min)

victornoel · 2019-01-27T20:15:10Z

@llorllale @borysfan the puzzle of #20 was removed instead of the one from #75...

victornoel · 2019-01-27T20:18:26Z

@llorllale also why is there two people working on #75 (see #79)

0crat · 2019-01-27T20:36:13Z

The job #87 is now out of scope

0crat · 2019-01-27T20:40:29Z

Order was finished: +15 point(s) just awarded to @fabriciofx /z

0crat · 2019-01-27T20:40:44Z

Job gh:llorllale/cactoos-matchers#87 doesn't exist in WBS, can't create order

0crat · 2019-01-27T20:46:30Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

borysfan · 2019-01-28T08:32:26Z

@victornoel Task #75 was assigned to me by @0crat. Please look in the history of #75. I thought that previous work done by @Iprogrammerr was abandoned.

0crat · 2019-01-28T08:32:39Z

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

victornoel · 2019-01-28T08:36:05Z

@borysfan yes, I can see that. But you removed the puzzle for #20, not the puzzle for #75, that's incorrect :)

borysfan · 2019-01-28T08:44:49Z

@borysfan yes, I can see that. But you removed the puzzle for #20, not the puzzle for #75, that's incorrect :)

@victornoel Ohh. Sorry for that. I think I still do not understand the puzzle idea. I am a little bit confused with the numbering. What should we do in this case?

victornoel · 2019-01-28T08:46:55Z

@borysfan you could create a new PR where you put back the previous puzzle and remove the correct one: like this you will get rewarded for closing #75 as expected and a new puzzle will be created for the previous #20. It a way it's not your fault, ARC and REV should have seen this ;) ARC will decide what to do with your PR anyway :)

borysfan · 2019-01-28T08:50:04Z

@victornoel Ok. I will do that. But we should also do something with other PR for #75. It might be confusing for other people.

victornoel · 2019-01-28T09:02:15Z

@borysfan no idea, I think it will resolve by itself, but now as a REV I know I should double-check this kind of things :)

borysfan · 2019-01-28T17:58:39Z

@victornoel I created PR which reverts PDD for #20. Issue #75 does not have any PDD in the code.

victornoel · 2019-01-28T21:52:38Z

@borysfan indeed, you should ask the person that opened #75 to close it now that it is solved

fabriciofx reviewed Jan 21, 2019

View reviewed changes

borysfan changed the title 75 #75 MatcherEnvelope for TypeSafeMatcher Jan 22, 2019

fabriciofx reviewed Jan 23, 2019

View reviewed changes

igor and others added 11 commits January 27, 2019 14:34

(llorllale#75) Envelope for TypeSafeMatcher

759ee60

(llorllale#75) Renamed Envelope to MatcherEnvelope

53c3d86

(llorllale#75) Added puzzle to extend MatcherEnvelope

41644f3

(llorllale#75) Fixed too short puzzle description

4db02aa

(llorllale#75) Checkstyle Indentation suppression on specific lines

73033be

(llorllale#75) Fixed wrong puzzle reference issue

ad8128b

(llorllale#75) Fixed build not passing

c0c0a8f

(llorllale#75) @checkstyle refactor. More precise descriptions in Jav…

328c5e8

…adoc. Test case for fail situation

(llorllale#75) Test case for value description

c359ec5

(llorllale#75) Removed PDD

1e36fe1

(llorllale#75) Code reformat. IsEqual changed into TextIs.

f6e4c3b

borysfan force-pushed the 75 branch from 24489ea to f6e4c3b Compare January 27, 2019 13:37

llorllale reviewed Jan 27, 2019

View reviewed changes

borysfan force-pushed the 75 branch from 7cdb78e to 7a0be0b Compare January 27, 2019 18:17

borysfan force-pushed the 75 branch from 7a0be0b to e8eeeb1 Compare January 27, 2019 18:22

(llorllale#75) JavaDoc changed. New puzzle added.

8dde23a

borysfan force-pushed the 75 branch from e8eeeb1 to 8dde23a Compare January 27, 2019 18:50

rultor merged commit 8dde23a into llorllale:master Jan 27, 2019

borysfan mentioned this pull request Jan 29, 2019

Envelope for TypeSafeMatcher - reduce the code duplication within the matchers #75

Closed

#75 MatcherEnvelope for TypeSafeMatcher #87

#75 MatcherEnvelope for TypeSafeMatcher #87

Conversation

borysfan commented Jan 21, 2019 • edited Loading

0crat commented Jan 21, 2019

codecov bot commented Jan 21, 2019 • edited Loading

Codecov Report

0crat commented Jan 21, 2019

fabriciofx commented Jan 21, 2019

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx commented Jan 23, 2019 • edited Loading

fabriciofx commented Jan 24, 2019

fabriciofx commented Jan 26, 2019

borysfan commented Jan 27, 2019

fabriciofx commented Jan 27, 2019

fabriciofx commented Jan 27, 2019

rultor commented Jan 27, 2019

llorllale Jan 27, 2019

Choose a reason for hiding this comment

borysfan Jan 27, 2019

Choose a reason for hiding this comment

llorllale commented Jan 27, 2019

borysfan commented Jan 27, 2019

llorllale commented Jan 27, 2019

rultor commented Jan 27, 2019

rultor commented Jan 27, 2019

victornoel commented Jan 27, 2019

victornoel commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

borysfan commented Jan 28, 2019

0crat commented Jan 28, 2019

victornoel commented Jan 28, 2019

borysfan commented Jan 28, 2019

victornoel commented Jan 28, 2019

borysfan commented Jan 28, 2019

victornoel commented Jan 28, 2019

borysfan commented Jan 28, 2019

victornoel commented Jan 28, 2019

borysfan commented Jan 21, 2019 •

edited

Loading

codecov bot commented Jan 21, 2019 •

edited

Loading

fabriciofx commented Jan 23, 2019 •

edited

Loading