InputHasContent.java:43-47: All the matchers should... #20
Comments
|
I can't create GitHub labels |
|
@llorllale/z please, pay attention to this issue |
|
@0crat in |
|
@llorllale Job #20 is now in scope, role is |
|
@llorllale, The scope of the task isn't clear for me.
? |
|
@dgroup I'm confused myself: this may not really apply. @victornoel can you help? |
|
@dgroup @llorllale there are two things in the todo:
|
|
@victornoel got it |
|
@victornoel, please correct me if i'm wrong, the test from EndsWith shoud be like /**
* Give the negative testing result for the invalid arguments.
*/
@Test
public void matchNegative() {
new Assertion<>(
"The matcher gives negative result for the invalid arguments",
() -> new EndsWith("!"),
new IsNot<>(new Matches<>(new TextOf("The sentence.")))
).affirm();
}
/**
* Matcher prints the actual value(s) properly in case of errors.
* The actual/expected section are using only when testing is failed and
* we need to explain what exactly went wrong.
*/
@Test
public void describeActualValues() {
new Assertion<>(
"The matcher print the value which came for testing",
() -> {
final Description desc = new StringDescription();
new EndsWith("").describeMismatch(new TextOf("ABC"), desc);
return desc.toString();
},
new IsEqual<>("Text ending with \"ABC\"")
).affirm();
}If we are on the same page, I can start the implementation. |
|
@victornoel, I understood. P.S: We are not using |
|
@dgroup in that case, it should look like this: new Assertion<>(
"doesn't match end of String",
() -> new TextOf("The sentence!"),
new EndsWith("!")
).affirm();Not the opposite. Also I suppose it would be good to introduce a secondary constructor for |
|
I also thought about secondary constructor, good idea. |
Sure. |
|
@llorllale I'm ok to implement this task. |
|
Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @llorllale/z |
@dgroup Can't understand "wait,", try one of these:
|
|
@0crat wait |
|
We have to wait for the #79 - Envelope for TypeSafeMatcher which will allow passing the lambda for |
|
The puzzle |
|
@llorllale I don't understand why removing the puzzle for this issue was accepted: this is not solved at all and the fix goes against what the puzzle was about |
|
The job #20 is now out of scope |
|
@victornoel we messed up, sorry |
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 13, 2021
Merged
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 13, 2021
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 13, 2021
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 14, 2021
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 14, 2021
victornoel
added a commit
to victornoel/cactoos-matchers
that referenced
this issue
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The puzzle
7-0cc4122bfrom #7 has to be resolved:cactoos-matchers/src/main/java/org/llorllale/cactoos/matchers/InputHasContent.java
Lines 43 to 47 in d3cd1e5
The puzzle was created by Victor Noël on 19-May-18.
Estimate: 30 minutes,
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
The text was updated successfully, but these errors were encountered: