Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#75) Reverting accidentally removed PDD #96

Merged

Conversation

borysfan
Copy link
Contributor

During implementation of #75 I accidentally removed PDD for #20. This change reverts removal.

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

@borysfan/z this pull request is too small, just 5 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @llorllale/z please review this and merge or reject

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #96   +/-   ##
=========================================
  Coverage     92.74%   92.74%           
  Complexity       89       89           
=========================================
  Files            21       21           
  Lines           248      248           
  Branches          3        3           
=========================================
  Hits            230      230           
  Misses           16       16           
  Partials          2        2
Impacted Files Coverage Δ Complexity Δ
...rg/llorllale/cactoos/matchers/InputHasContent.java 100% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fadace...cb0a996. Read the comment docs.

@borysfan
Copy link
Contributor Author

@llorllale Could you please review my PR.

@llorllale
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 30, 2019

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cb0a996 into llorllale:master Jan 30, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 30, 2019

@rultor merge

@llorllale Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Job gh:llorllale/cactoos-matchers#96 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants