familiar functions changes

[taltamir]

replaced forbidFamChange() with canChangeFamiliar()
replaced forbidFamChange(familiar target) with canChangeToFamiliar(familiar target)
This is not a rename, but an inversion of the logic from asking a negative to asking a positive.
Adjusted the functions to have inverted logic.
Adjusted all instances in which it is used to invert the logic. (by adding or removing ! as appropriate)

How Has This Been Tested?

Validated autoscend.ash

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have based by pull request against the beta branch or have a good reason not to.

[taltamir]

And just to note. Yes I have seen some places where the code that uses those functions can be improved. at the moment I am just doing a rename and ! flip because this touches too many files and I don't want it to get constantly blocked. not to mention being too big to handle for reviewers.

I had already previously addressed those long ago in my old old pokefam branch. I will reapply improvements as needed in future PRs. each being reasonably sized and easy to review

[Malibu-Stacey]

And just to note. Yes I have seen some places where the code that uses those functions can be improved. at the moment I am just doing a rename and ! flip because this touches too many files and I don't want it to get constantly blocked. not to mention being too big to handle for reviewers.

I had already previously addressed those long ago in my old old pokefam branch. I will reapply improvements as needed in future PRs. each being reasonably sized and easy to review

I hadn't read this when I started reviewing. The only change I'd request in this case is #317 (comment)

[taltamir]

I hadn't read this when I started reviewing. The only change I'd request in this case is #317 (comment)

Change made.
And thank you for the other suggestions. I will make all the other changes you suggested in a future commit after the name change goes through. I had to force myself to NOT start doing them this time around :)

[taltamir]

Git is auto hiding this comment so reposting it.
RELEASE/scripts/autoscend/auto_community_service.ash
near line 3334
if(!have_familiar($familiar[Machine Elf]) && canChangeFamiliar())
this needs refactoring. it makes no sense.

1. it is specifically testing if there is NOT a machine elf. probably an error?
2. it is a nested if, underneath it is code for handling smithing tome. which has nothing to do with machine elf. why would having machine elf matter to using the smithing tome? I am of the opinion that this line need to be removed entirely and just check the smithing tome directly to see if should be used

[taltamir]

I figured it out. machine elf pet is used as an alternative to louder than bomb. so that one specific line should have been
if(!canChangeToFamiliar($familiar[Machine Elf]))

done @ commit 8ceb0c4