Path Heavy Rains issues combo tracker

[taltamir]

This is a ticket for keeping track of various heavy rains issues that currently exist.

[taltamir]

Ongoing Issues

subissue 4

OBSOLETE. we no longer rely on switching CCS. as such this mafia bug is no longer relevant to us...
Heavy rains is failing to switch CCS to autoscend_null, resulting in it erroring out until i manually switch it over.

customCombatScript is set to unrecognized 'rain', should be 'autoscend_null'
Stack trace:
  at handlePreAdventure (auto_pre_adv.ash:18)
  at handlePreAdventure (auto_pre_adv.ash:6)
  at main (auto_pre_adv.ash:360)
Stack trace:
  at rainManSummon (auto_heavyrains.ash:503)
  at rainManSummon (auto_heavyrains.ash:525)
  at hr_initializeDay (auto_heavyrains.ash:150)
  at initializeDay (autoscend.ash:2176)
  at auto_begin (autoscend.ash:15150)
  at safe_preference_reset_wrapper (autoscend.ash:15277)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
printStackOnAbort => false

customCombatScript is set to unrecognized 'HCCS', should be 'autoscend_null'
Stack trace:
  at handlePreAdventure (auto_pre_adv.ash:18)
  at handlePreAdventure (auto_pre_adv.ash:6)
  at main (auto_pre_adv.ash:360)
Stack trace:
  at rainManSummon (auto_heavyrains.ash:503)
  at rainManSummon (auto_heavyrains.ash:525)
  at hr_initializeDay (auto_heavyrains.ash:150)
  at initializeDay (autoscend.ash:2176)
  at auto_begin (autoscend.ash:15150)
  at safe_preference_reset_wrapper (autoscend.ash:15277)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
  at safe_preference_reset_wrapper (autoscend.ash:15284)
printStackOnAbort => false

This might possibly be related to this mafia bug:
https://kolmafia.us/showthread.php?24886-Some-mafia-settings-don-t-actually-change-unless-you-change-them-in-the-UI&p=157033#post157033
However, it might be an us bug instead. because mafia can successfully change CCS via command given by a script. So either we are failing to call it in heavy rains, or mafia can change CCS via script command except from heavy rains where it can't.

[Malibu-Stacey]

I'd suggest putting hippy war issues in their own issue or appending them to #167 as they're not specific to Heavy Rains.

[taltamir]

Good point. Reorganized

[taltamir]

Universal Issues

These issues were determined to be universal and not specific to heavy rains.
As such even if they are not yet resolved they should not block this ticket from closing.
Those issues should all be spun off into their own independent ticket

subissue 2

Issue #271

subissue 5

Issue #270

subissue 6

issue #71

[taltamir]

Already Fixed Issues:

subissue 1

PR #316

The final boss https://kol.coldfront.net/thekolwiki/index.php/The_Rain_King
could be optimized for its own unique rules
IIRC it lost a battle against it first time i did a run, but my second heavy rains autoscend run won the battle against it on the first try just now. Albeit a very inefficient win.
Main thing is to grab lots of cheap buffs against it (it removes 1 a round instead of all at once like naughty sorceress does). And grab any passive damage you can.
Also at begining of battle it strips all your gear except main hand and off hand.
And it has a hard cap of 40 damage per source. So you need to use multi sourced stuff, an offhand mateorb is good here. As well as all passive or retaliatory damage sources.

subissue 3

PR #316

At the end of the day I got

[INFO] - Copies left: 0
[INFO] - Pulls remaining: 6
[INFO] - If you have the Frat Warrior Fatigues, rain man an Astronomer? Skinflute?
[INFO] - You have a rain man to cast, please do so before overdrinking and run me again.

Instead of telling me, it should automatically use it. In my case the best choice would have been lobsterfrogman. although skinflute or ghost were valid too.

subissue 7

PR #316

Issue #194

subissue 8

Various univeral hippy related L12 war issues
merge #265
A heavy rains specific issue remained where rainman will only copy a fratboy for the frat war outfit regardless of which side it fights for.
This was fixed in subsequent merge

subissue 9

fixed: hole handling was universally a bit broken and I have since fixed it. And testing shows that the general fix works in heavy rains

The skill https://kol.coldfront.net/thekolwiki/index.php/Rain_Man
is used to acquire the components of the star key in order to skip the hole in the sky.
As a result autoscend does not bother to unlock the hole in the sky.
Which results in shen's quest stalling on the 3rd task of fighting a monster in the hole in the sky (since back in the day it would have gone the pirate route).
So I had to manually unlock it and then finished the palindrome quest on my own... I am not sure if it would have been able to finish that quest on its own or not had i reran autoscend as soon as i unlocked the hole in the sky

[taltamir]

TODO

1. assaultFamiliar function that sets best damage familiar for boss fight. can be used for both regular sorceress fight and her replacement in heavy rains, probably a few other bosses in heavy rains... and actually everywhere where warbear assault drone is used.

2. I made an error when preparing to fight the rain king. it equipped the green lantern momentarily but then unequipped it before the battle. switching to a maximizer result
   the result of which was weapon: something or another fan that deals prismatic damage, offhand lightsaber
   it should have been offhand green-lantern with weapon being maximized for spell damage percent
   also should add 1handed when optimizing spell damage percent. and pulling meteorb if appropriate.

3. buffMaintain should be using
   maximize("-mana cost, -tie", false);
   before casting a buff to reduce the buff costs. maybe it already is?