[RST-6280] Support for YAML 6.0+ #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svwilliams
requested changes
Nov 4, 2022
copyrightify/copyrightify.py
Outdated
| @@ -168,7 +168,7 @@ def process_paths(paths, recursive, config, context): | |||
|
|
|||
| def main(): | |||
| try: | |||
| config = yaml.load(resource_string(__name__, 'config.yaml')) | |||
| config = yaml.load(resource_string(__name__, 'config.yaml'), Loader=yaml.FullLoader) | |||
There was a problem hiding this comment.
I think it is generally recommended to use the safe_load command instead of the load command.
https://security.openstack.org/guidelines/dg_avoid-dangerous-input-parsing-libraries.html
Which I think is basically the equivalent of Loader=yaml.SafeLoader.
svwilliams
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a line which will remove the error
Error: load() missing 1 required positional argument: 'Loader'.Related PR: yaml/pyyaml#561
The branch protection rules were not set for the
master. I have added them as well. Please have a look at them too.Tested versions:
python: 3.8yaml: 6.0