Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RST-6280] Support for YAML 6.0+ #2

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[RST-6280] Support for YAML 6.0+ #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab94d9
support yaml 6.0+
ShivamThukral Nov 4, 2022
3407d89
safe loader
ShivamThukral Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion copyrightify/copyrightify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def process_paths(paths, recursive, config, context):

def main():
try:
config = yaml.load(resource_string(__name__, 'config.yaml'))
config = yaml.load(resource_string(__name__, 'config.yaml'), Loader=yaml.FullLoader)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is generally recommended to use the safe_load command instead of the load command.
https://security.openstack.org/guidelines/dg_avoid-dangerous-input-parsing-libraries.html
Which I think is basically the equivalent of Loader=yaml.SafeLoader.


parser = argparse.ArgumentParser()
parser.add_argument('paths', type=str, nargs='+', help='Path to process')
Expand Down