Optimize info_disks #164
Merged
Optimize info_disks #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces the `Add-Type` implementation with one that uses `System.IO.DriveInfo` - For once, my new implementation is actually shorter than the previous one - Significantly faster on both fast and slow systems
jcwillox
approved these changes
Oct 27, 2022
|
Very cool! This is basically the same implementation which was removed in #94, the only difference being it uses |
rashil2000
reviewed
Nov 2, 2022
rashil2000
reviewed
Nov 2, 2022
Co-authored-by: Rashil Gandhi <[email protected]>
rashil2000
added a commit
that referenced
this pull request
Nov 3, 2022
* New Method Working - Replaces the `Add-Type` implementation with one that uses `System.IO.DriveInfo` - For once, my new implementation is actually shorter than the previous one - Significantly faster on both fast and slow systems * Apply suggestions from code review Co-authored-by: Rashil Gandhi <[email protected]> Co-authored-by: Rashil Gandhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-Typeimplementation with one that usesSystem.IO.DriveInfo