Rewrote disk_info to use Windows API calls instead of WMIC. Renamed o…

[AwesomeCronk]

…ld disk_info to disk_info_CIM.

Fixes #93

[rashil2000]

I'm only getting C: drive's information when ShowDisks is set to *.

It showed all three (C:, D:, E:) before.

[AwesomeCronk]

Interesting… Not sure what caused that because I was able to get an array of all the disks in my system, even my USB hub’s attachment points. I must have forgotten to actually show all disks and figures only C: chowed up because it was the only one with media in it.

[rashil2000]

Hmm. All 3 of my drives have significant usage so this is probably something that we'll have to fix before this is merged.

[AwesomeCronk]

Yes, it most definitely is. I am in the middle of some sleuthing around and I have found that my method of checking if the array $showDisks contains each $diskLetter was not working. I redid that and got that part to work, but now I have come across the issue that from some reason, the values that [WinAPI.DiskMethods]::GetDiskFreeSpaceEx writes to are overridden to 0 on each consecutive pass. C: is my only drive that isn't virtual or an empty hub/cd drive, so I am going to do some testing with media in them.

[AwesomeCronk]

Decided to check the success flag returned by the API call. Gotta love this...

In this case E: actually had media in it, so I have no clue why it won't work.

[AwesomeCronk]

Running the same loop that checks the disk usage in winfetch at the terminal works, though it fails inside winfetch. No idea why.

[AwesomeCronk]

Much better!

I found it to be related to the PowerShell/C# interop layer. For whatever reason, the System.String[] that splitting the C# string[] returned for GetLogicalDriveStringsW was designed to be close enough to System.Object[] that I could do all that without errors, but refused to pass correctly to GetDiskFreeSpaceEx. That should all be fixed now.

[rashil2000]

Great! It's working slick now.

If you have a Win 7 machine or VM lying around, please test it there. If there are no problems, we can get rid of the info_disk_CIM function.

[AwesomeCronk]

I lack a win7 machine. I’ll ask around and see if I know someone who does and if I can find someone I’ll see if they are ok with testing it.

[rashil2000]

Just tested it in a VM, works fine.

Please remove the old function.

[AwesomeCronk]

Will do 👍

[rashil2000]

Great, thanks for the awesome contribution!

[jcwillox]

Great job, seems to work perfectly and is even faster than before 👍

[AwesomeCronk]

Thank you! Happy to have been able to help!