General: Allow instructors to navigate from course management to student view

[MaximilianAnzinger]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Motivation and Context

Instructors have no easy way to navigate from course management back to the student view.
Resolves #7596 .

Description

Adds same button we use to navigate from the student view to management to the management view to navigate back.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Student
• 1 Course

1. Log in to Artemis as Instructor
2. Navigate to Course Management of your Course
3. Click the Student view button to navigate back to the student view
4. Make sure you can now see the Manage button again
5. Repeat this for subpages (e.g. Statistics, Lectures, etc.). You should always get redirected to the course main page or the main management page respectively.
6. Log in to Artemis as Student
7. Navigate to the Course
8. Make sure you can't see the Manage button

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
header-course.component.ts	100%	✅

�

Screenshots

[AntonGeTUM]

Manually tested, works as expected

[xHadie]

Manually tested on TS3_Legacy
Works as expected!

[Gusti2010]

Manually tested on TS11_Legacy. Everything works as expected!

[JanaNF]

Manual tested on legacy_ts2. Worked as expected.

[Strohgelaender]

code

[egekurt123]

Manually tested on artemis-test-4: Everything works as expected when acting as a student, however when I go to the communication or messages subpage as an instructor it automatically puts me into the student "view" (I can change back to instructor view however with the manage button) I don't know if this is wanted?

This problem also occurs in other versions. There is already an issue ticket for that.

[Ceiridge]

Tested on test5 and it works as expected, except that it puts me back to another subpage when I click on Student view

[JohannesStoehr]

Code looks good to me

[georgyia]

Tested on two services manually (ts1, ts3), tested with artemis_test_user_11 and artemis_test_user_12. There is student view button.

[MaximilianAnzinger]

Manually tested on artemis-test-4: Everything works as expected when acting as a student, however when I go to the communication or messages subpage as an instructor it automatically puts me into the student "view" (I can change back to instructor view however with the manage button) I don't know if this is wanted?

This problem also occurs in other versions. There is already an issue ticket for that.

Is this really an issue? I always thought that was intentional. I mean what would you expect to see differently on the communication view?

[MaximilianAnzinger]

Tested on two services manually (ts1, ts3), tested with artemis_test_user_11 and artemis_test_user_12. There is student view button.

Are you sure you used the correct test servers (legacy vs gh)? It seems pretty unlikely that it's working on so many servers bot not on these.

[sarpsahinalp]

It seems to be working fine. But when pressed on Communication or Messages it seems to turning back to student view no matter what I do. It seems this issue is already mentioned on another issue.

[MaximilianAnzinger]

It seems to be working fine. But when pressed on Communication or Messages it seems to turning back to student view no matter what I do. It seems this issue is already mentioned on another issue.

Afaik this is intentional. Maybe @lennart-keller can say more about this.
When clicking on those tabs you essentially navigate to the normal conversation page which is not part of the management view.

[lennart-keller]

It seems to be working fine. But when pressed on Communication or Messages it seems to turning back to student view no matter what I do. It seems this issue is already mentioned on another issue.

Afaik this is intentional. Maybe @lennart-keller can say more about this. When clicking on those tabs you essentially navigate to the normal conversation page which is not part of the management view.

Yes, this is intentional. There are no management pages for communication and messaging.

[sarpsahinalp]

Tested on ts5 again seems to be working.