Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sounds playing for objects not sent to the client #15734

Closed
wants to merge 2 commits into from
Closed

Fix sounds playing for objects not sent to the client #15734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790c032
Fix sounds playing for objects not sent to the client
Emojigit Jan 29, 2025
15e3389
fix
sfan5 Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/network/clientpackethandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,13 +846,13 @@ void Client::handleCommand_PlaySound(NetworkPacket* pkt)
break;
case SoundLocation::Object: {
ClientActiveObject *cao = m_env.getActiveObject(object_id);
v3f vel(0.0f);
if (cao) {
pos = cao->getPosition() * (1.0f/BS);
vel = cao->getVelocity() * (1.0f/BS);
v3f vel = cao->getVelocity() * (1.0f/BS);
m_sound->playSoundAt(client_id, spec, pos, vel);
break;
}
m_sound->playSoundAt(client_id, spec, pos, vel);
break;
[[fallthrough]];
}
default:
// Unknown SoundLocation, instantly remove sound
Expand Down
Loading