Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1447 removed titles #1475

Merged
merged 7 commits into from
Oct 17, 2018
Merged

Fabo/1447 removed titles #1475

merged 7 commits into from
Oct 17, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Oct 17, 2018

Closes #1447

Description:

❤️ Thank you!

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #1475 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1475   +/-   ##
========================================
  Coverage    96.76%   96.76%           
========================================
  Files           89       89           
  Lines         1702     1702           
  Branches        80       80           
========================================
  Hits          1647     1647           
  Misses          45       45           
  Partials        10       10
Impacted Files Coverage Δ
...src/renderer/components/common/PagePreferences.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.78% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/wallet/PageSend.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 91.42% <ø> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some title suggestions for gov

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit d64845f into develop Oct 17, 2018
@fedekunze fedekunze deleted the fabo/1447-no-titles branch October 17, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove titles from pages
2 participants