Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1447 removed titles #1475

Merged
merged 7 commits into from
Oct 17, 2018
Merged

Fabo/1447 removed titles #1475

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
705d708
removed titles
Oct 17, 2018
f55524e
Merge branch 'develop' into fabo/1447-no-titles
faboweb Oct 17, 2018
5c1f972
Update app/src/renderer/components/govern/PageProposalsNewText.vue
fedekunze Oct 17, 2018
deb582e
Update app/src/renderer/components/govern/PageProposalsNewCreate.vue
fedekunze Oct 17, 2018
e5a2f03
Update app/src/renderer/components/govern/PageProposalsNewAmend.vue
fedekunze Oct 17, 2018
65a3cba
Update app/src/renderer/components/govern/PageProposalsNewUpgrade.vue
fedekunze Oct 17, 2018
7bdb87a
Update app/src/renderer/components/govern/PageProposalsNewAdjust.vue
fedekunze Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Changed

* Changed minor component of version number to match testnet version. @NodeGuy
* Updated contribution guidelines. @faboweb
* #1183 Changed a bunch of JavaScript files to strict mode. @NodeGuy
* Updated contribution guidelines. @faboweb
* #1447 Removed titles from all pages. @faboweb

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/common/Page404.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title='404 - Page Not Found')
tm-page(data-title='404')
tm-part(title='Try another page...')
tm-list-item(to='/' title='Wallet')
tm-list-item(to='/staking' title='Staking')
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/common/PagePreferences.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title="Preferences")
tm-page(data-title="Preferences")
div(slot="menu"): vm-tool-bar

tm-part(title='Settings')
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(:title='proposal.title')
tm-page(data-title='Proposal')
div(slot="menu"): vm-tool-bar
a(@click="commentOnProposal(proposal.id)"): i.material-icons comment
a(@click="proposalIsSpam(proposal.id)"): i.material-icons error
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposals.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title='Proposals')
tm-page(data-title='Proposals')
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'New Proposal'")
i.material-icons add
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNew.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title='New Proposal')
tm-page(data-title='New Proposal')
div(slot="menu"): vm-tool-bar
router-link(to="/proposals" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNewAdjust.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title="Proposal: Adjust Parameters")
tm-page(data-title="Proposal: Adjust Parameters")
faboweb marked this conversation as resolved.
Show resolved Hide resolved
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNewAmend.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title="Proposal: Amend Constitution")
tm-page(data-title="Proposal: Amend Constitution")
faboweb marked this conversation as resolved.
Show resolved Hide resolved
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNewCreate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(:title="`Proposal: Create ${bondingDenom}s`")
tm-page(data-title="`Proposal: Create ${bondingDenom}s`")
faboweb marked this conversation as resolved.
Show resolved Hide resolved
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNewText.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title="Proposal: Freeform Text")
tm-page(data-title="Proposal: Freeform Text")
faboweb marked this conversation as resolved.
Show resolved Hide resolved
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/govern/PageProposalsNewUpgrade.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(title="Proposal: Upgrade Code")
tm-page(data-title="Proposal: Upgrade Code")
faboweb marked this conversation as resolved.
Show resolved Hide resolved
div(slot="menu"): vm-tool-bar
router-link(to="/proposals/new" exact v-tooltip.bottom="'Back'")
i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/staking/PageStaking.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(data-title="Staking", :title="config.devMode ? '' : 'Staking'")
tm-page(data-title="Staking")
template(slot="menu-body")
tm-balance(:tabs="tabs")

Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/staking/PageValidator.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page
tm-page(data-title="Validator")
template(slot="menu-body", v-if="config.devMode"): tm-balance
div(slot="menu"): tm-tool-bar
router-link(to="/staking" exact): i.material-icons arrow_back
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/wallet/PageSend.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang='pug'>
tm-page(title='Send')
tm-page(data-title='Send')
div(slot="menu"): vm-tool-bar
tm-form-struct(:submit="onSubmit")
tm-part(title='Denomination Options')
Expand Down
2 changes: 1 addition & 1 deletion app/src/renderer/components/wallet/PageWallet.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template lang="pug">
tm-page(data-title="Wallet", :title="config.devMode ? '' : 'Wallet'")
tm-page(data-title="Wallet")
template(slot="menu-body", v-if="config.devMode"): tm-balance
div(slot="menu")
vm-tool-bar
Expand Down
9 changes: 2 additions & 7 deletions test/unit/specs/components/common/__snapshots__/Page404.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`Page404 has the expected html structure 1`] = `
<div
class="tm-page"
data-title="404"
>
<header
class="tm-page-header"
Expand All @@ -13,13 +14,7 @@ exports[`Page404 has the expected html structure 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
404 - Page Not Found
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down
9 changes: 2 additions & 7 deletions test/unit/specs/components/common/__snapshots__/PagePreferences.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`PagePreferences has the expected html structure if connected 1`] = `
<div
class="tm-page"
data-title="Preferences"
>
<header
class="tm-page-header"
Expand All @@ -13,13 +14,7 @@ exports[`PagePreferences has the expected html structure if connected 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Preferences
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down
3 changes: 3 additions & 0 deletions test/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`PageValidator has the expected html structure 1`] = `
<div
class="tm-page"
data-title="Validator"
>
<header
class="tm-page-header"
Expand Down Expand Up @@ -445,6 +446,7 @@ exports[`PageValidator has the expected html structure 1`] = `
exports[`PageValidator shows a default avatar 1`] = `
<div
class="tm-page"
data-title="Validator"
>
<header
class="tm-page-header"
Expand Down Expand Up @@ -869,6 +871,7 @@ exports[`PageValidator shows a validator as candidate if he has no voting_power
exports[`PageValidator shows an error if the validator couldn't be found 1`] = `
<div
class="tm-page"
data-title="Validator"
>
<header
class="tm-page-header"
Expand Down
72 changes: 16 additions & 56 deletions test/unit/specs/components/wallet/__snapshots__/PageSend.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`PageSend disables sending if not connected 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -13,13 +14,7 @@ exports[`PageSend disables sending if not connected 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -347,6 +342,7 @@ exports[`PageSend disables sending if not connected 1`] = `
exports[`PageSend has the expected html structure 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -357,13 +353,7 @@ exports[`PageSend has the expected html structure 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -719,6 +709,7 @@ exports[`PageSend has the expected html structure 1`] = `
exports[`PageSend should show address required error 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -729,13 +720,7 @@ exports[`PageSend should show address required error 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -1061,6 +1046,7 @@ exports[`PageSend should show address required error 1`] = `
exports[`PageSend should show bech32 error when address length is too long 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -1071,13 +1057,7 @@ exports[`PageSend should show bech32 error when address length is too long 1`] =
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -1403,6 +1383,7 @@ exports[`PageSend should show bech32 error when address length is too long 1`] =
exports[`PageSend should show bech32 error when address length is too short 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -1413,13 +1394,7 @@ exports[`PageSend should show bech32 error when address length is too short 1`]
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -1745,6 +1720,7 @@ exports[`PageSend should show bech32 error when address length is too short 1`]
exports[`PageSend should show bech32 error when alphanumeric is wrong 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -1755,13 +1731,7 @@ exports[`PageSend should show bech32 error when alphanumeric is wrong 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -2098,6 +2068,7 @@ Object {
exports[`PageSend should trigger confirmation modal if form is corect 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -2108,13 +2079,7 @@ exports[`PageSend should trigger confirmation modal if form is corect 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down Expand Up @@ -2530,6 +2495,7 @@ exports[`PageSend should trigger confirmation modal if form is corect 1`] = `
exports[`PageSend should work without providing a default denom 1`] = `
<div
class="tm-page"
data-title="Send"
>
<header
class="tm-page-header"
Expand All @@ -2540,13 +2506,7 @@ exports[`PageSend should work without providing a default denom 1`] = `
<div
class="tm-page-header-text"
>
<div
class="tm-page-header-title"
>
<h2>
Send
</h2>
</div>
<!---->
<!---->
<!---->
</div>
Expand Down