Fabo/1573 sent errors via raven #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1624 +/- ##
===========================================
+ Coverage 97.56% 97.68% +0.11%
===========================================
Files 100 100
Lines 2012 2029 +17
Branches 93 93
===========================================
+ Hits 1963 1982 +19
+ Misses 39 37 -2
Partials 10 10
|
fedekunze
reviewed
Nov 22, 2018
fedekunze
reviewed
Nov 22, 2018
fedekunze
reviewed
Nov 22, 2018
fedekunze
reviewed
Nov 22, 2018
fedekunze
suggested changes
Nov 22, 2018
|
done @fedekunze |
fedekunze
reviewed
Nov 22, 2018
| @@ -30,6 +32,7 @@ export default ({ node }) => { | |||
| title: `Error fetching governance parameters`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
| @@ -39,6 +39,7 @@ export default ({ node }) => { | |||
| title: `Error fetching proposals`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
| @@ -24,6 +24,7 @@ export default ({ node }) => { | |||
| title: `Error fetching votes`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
| @@ -57,6 +58,7 @@ export default ({}) => { | |||
| title: `Error fetching keybase information for validators`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
| @@ -23,6 +25,7 @@ export default ({ node }) => { | |||
| title: `Error fetching staking parameters`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
| try { | ||
| let keys = await node.keys.values() | ||
| commit(`setAccounts`, keys) | ||
| } catch (err) { | ||
| Raven.captureException(err) |
| @@ -61,15 +60,20 @@ export default ({ node }) => { | |||
| dl: `/session/` + screen | |||
| }) | |||
| }, | |||
| async loadAccounts({ commit }) { | |||
| async loadAccounts({ commit, state }) { | |||
| state.loading = true | |||
| try { | |||
| let keys = await node.keys.values() | |||
| commit(`setAccounts`, keys) | |||
| } catch (err) { | |||
| @@ -132,7 +142,9 @@ export default ({ node }) => { | |||
|
|
|||
| function onTx(err, event) { | |||
| if (err) { | |||
| @@ -116,25 +117,16 @@ describe(`Module: Transactions`, () => { | |||
| expect(node.txs).not.toHaveBeenCalled() | |||
| }) | |||
|
|
|||
| it(`should set error to true if dispatches fail`, () => { | |||
| it(`should set error to true if enriching transactions fail`, async () => { | |||
| let err = new Error(`unexpected error`) | |||
| @@ -65,6 +67,7 @@ export default ({ node }) => { | |||
| title: `Error fetching block information`, | |||
| body: err.message | |||
| }) | |||
| Raven.captureException(err) | |||
|
boy, I don't want to refactor the whole repo in this PR ;P We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1573
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer